fix(buffers): make the parent node for terminals expandable (#1761)

Author: pynappo

lua/neo-tree/sources/common/commands.lua

@@ -723,17 +723,14 @@ M.toggle_directory = function(state, toggle_directory)
   M.toggle_node(state, toggle_directory)
 end
 
----Open file or directory
+---Open file or expandable node
 ---@param state table The state of the source
 ---@param open_cmd string The vim command to use to open the file
 ---@param toggle_directory function The function to call to toggle a directory
 ---open/closed
 local open_with_cmd = function(state, open_cmd, toggle_directory, open_file)
   local tree = state.tree
   local success, node = pcall(tree.get_node, tree)
-  if node.type == "message" then
-    return
-  end
   if not (success and node) then
     log.debug("Could not get node.")
     return
@@ -762,13 +759,13 @@ local open_with_cmd = function(state, open_cmd, toggle_directory, open_file)
   end
 
   local config = state.config or {}
-  if node.type ~= "directory" and config.no_expand_file ~= nil then
+  if node.type == "file" and config.no_expand_file ~= nil then
     log.warn("`no_expand_file` options is deprecated, move to `expand_nested_files` (OPPOSITE)")
     config.expand_nested_files = not config.no_expand_file
   end
-  if node.type == "directory" then
-    M.toggle_node(state, toggle_directory)
-  elseif node:has_children() and config.expand_nested_files and not node:is_expanded() then
+
+  local should_expand_file = config.expand_nested_files and not node:is_expanded()
+  if utils.is_expandable(node) and (node.type ~= "file" or should_expand_file) then
     M.toggle_node(state, toggle_directory)
   else
     open()

lua/neo-tree/utils/init.lua

@@ -1127,7 +1127,7 @@ M.truthy = function(value)
 end
 
 M.is_expandable = function(node)
-  return node.type == "directory" or node:has_children()
+  return node:has_children() or node.type == "directory"
 end
 
 M.windowize_path = function(path)