refactor: move all tree:render calls to a central location

Author: cseickel

lua/neo-tree/sources/common/commands.lua

@@ -41,7 +41,7 @@ end
 
 M.close_all_nodes = function(state)
   renderer.collapse_all_nodes(state.tree)
-  state.tree:render()
+  renderer.redraw(state)
 end
 
 M.close_node = function(state, callback)
@@ -58,7 +58,7 @@ M.close_node = function(state, callback)
 
   if target_node and target_node:has_children() then
     target_node:collapse()
-    tree:render()
+    renderer.redraw(state)
     renderer.focus_node(state, target_node:get_id())
   end
 end
@@ -202,7 +202,7 @@ local open_with_cmd = function(state, open_cmd, toggle_directory)
         updated = node:expand()
       end
       if updated then
-        tree:render()
+        renderer.redraw(state)
       end
     end
   else
@@ -240,7 +240,7 @@ end
 ---@param toggle_directory function The function to call to toggle a directory
 ---open/closed
 M.open_tabnew = function (state, toggle_directory)
-  open_with_cmd(state, "tabnew", toggle_directory) 
+  open_with_cmd(state, "tabnew", toggle_directory)
 end
 
 M.rename = function(state, callback)
@@ -266,7 +266,7 @@ M.toggle_node = function(state, toggle_directory)
       updated = node:expand()
     end
     if updated then
-      tree:render()
+      renderer.redraw(state)
     end
   end
 end

lua/neo-tree/sources/filesystem/init.lua

@@ -85,7 +85,7 @@ local follow_internal = function(callback, force_show)
         end
       end
       if state_changed then
-        state.tree:render()
+        renderer.redraw(state)
       end
     end
   end
@@ -369,7 +369,7 @@ M.toggle_directory = function(state, node)
       state.explicitly_opened_directories[node:get_id()] = true
     end
     if updated then
-      tree:render()
+      renderer.redraw(state)
     end
   end
 end

lua/neo-tree/sources/manager.lua

@@ -226,9 +226,7 @@ M.diagnostics_changed = function(source_name, args)
   end
   M._for_each_state(source_name, function(state)
     state.diagnostics_lookup = args.diagnostics_lookup
-    if state.path and renderer.window_exists(state) then
-      state.tree:render()
-    end
+    renderer.redraw(state)
   end)
 end
 
@@ -256,9 +254,7 @@ M.git_status_changed = function(source_name, args)
   M._for_each_state(source_name, function(state)
     if utils.is_subpath(args.git_root, state.path) then
       state.git_status_lookup = args.git_status
-      if renderer.window_exists(state) then
-        state.tree:render()
-      end
+      renderer.redraw(state)
     end
   end)
 end
@@ -372,9 +368,7 @@ end
 -- rendered.
 M.redraw = function(source_name)
   M._for_each_state(source_name, function(state)
-    if state.tree and renderer.window_exists(state) then
-      state.tree:render()
-    end
+    renderer.redraw(state)
   end)
 end
 

lua/neo-tree/ui/renderer.lua

@@ -441,6 +441,15 @@ M.position = {
   is = { restorable = true },
 }
 
+---Redraw the tree without relaoding from the source.
+---@param state table State of the tree.
+M.redraw = function(state)
+  if state.tree and M.window_exists(state) then
+    log.trace("Redrawing tree", state.name, state.id)
+    state.tree:render()
+    log.trace("  Redrawing tree done", state.name, state.id)
+  end
+end
 ---Visit all nodes ina tree recursively and reduce to a single value.
 ---@param tree table NuiTree
 ---@param memo any Value that is passed to the accumulator function