fix: prevent invalid window id by wrapping state.position.save in pcall, fixes #102

Author: cseickel

lua/neo-tree/sources/filesystem/init.lua

@@ -144,7 +144,12 @@ local navigate_internal = function(path, path_to_reveal, callback)
       handled = follow_internal(callback, true)
     end
     if not handled then
-      state.position.save()
+      local success, msg = pcall(state.position.save)
+      if success then
+        log.trace("navigate_internal: position saved")
+      else
+        log.trace("navigate_internal: FAILED to save position: ", msg)
+      end
       fs_scan.get_items_async(state, nil, nil, callback)
     end
   end

lua/neo-tree/sources/manager.lua

@@ -36,7 +36,7 @@ local function create_state(tabnr, sd)
   state.dirty = true
   state.position = {
     save = function()
-      if state.tree and renderer.is_window_valid(state.winid) then
+      if state.tree and renderer.window_exists(state) then
         local node = state.tree:get_node()
         if node then
           state.position.node_id = node:get_id()
@@ -180,7 +180,7 @@ M.dir_changed = function(source_name)
   if state.path and cwd == state.path then
     return
   end
-  if renderer.window_exists(state) then
+  if state.path and renderer.window_exists(state) then
     M.navigate(source_name, cwd)
   else
     state.path = cwd

lua/neo-tree/ui/renderer.lua

@@ -489,8 +489,10 @@ M.window_exists = function(state)
     local isvalid = M.is_window_valid(state.winid)
     window_exists = isvalid and (vim.api.nvim_win_get_number(state.winid) > 0)
     if not window_exists then
+      state.winid = nil
       local bufnr = utils.get_value(state, "bufnr", 0, true)
       if bufnr > 0 and vim.api.nvim_buf_is_valid(bufnr) then
+        state.bufnr = nil
         local success, err = pcall(vim.api.nvim_buf_delete, bufnr, { force = true })
         if not success and err:match("E523") then
           vim.schedule_wrap(function()