TEST: Improve warning filters, check set_zooms behavior more thoroughly

Author: effigies

nibabel/tests/test_nifti1.py

@@ -85,6 +85,7 @@ def setUp(self):
         self._wctx = warnings.catch_warnings()
         self._wctx.__enter__()
         warnings.filterwarnings('ignore', 'get_zooms', FutureWarning)
+        warnings.filterwarnings('ignore', 'set_zooms', FutureWarning)
         warnings.filterwarnings('ignore', 'Unknown (spatial|time) units',
                                 UserWarning)
 
@@ -779,6 +780,7 @@ def setUp(self):
         self._wctx = warnings.catch_warnings()
         self._wctx.__enter__()
         warnings.filterwarnings('ignore', 'get_zooms', FutureWarning)
+        warnings.filterwarnings('ignore', 'set_zooms', FutureWarning)
         warnings.filterwarnings('ignore', 'Unknown (spatial|time) units',
                                 UserWarning)
 
@@ -1129,7 +1131,6 @@ def test_zooms_edge_cases(self):
         aff = np.eye(4)
         img = img_klass(arr, aff)
 
-
         # Unknown units = 2 warnings
         with clear_and_catch_warnings() as warns:
             warnings.simplefilter('always')
@@ -1172,16 +1173,37 @@ def test_zooms_edge_cases(self):
         assert_array_almost_equal(img.header.get_zooms(units='norm'),
                                   (1, 1, 1, 0.000001))
 
-        # Verify `set_zooms(units='norm')` resets units
         img.header.set_xyzt_units(xyz='meter', t='usec')
         assert_equal(img.header.get_xyzt_units(), ('meter', 'usec'))
+
+        # Verify `set_zooms(units='raw')` leaves units unchanged
+        img.header.set_zooms((2, 2, 2, 2.5), units='raw')
+        assert_array_almost_equal(img.header.get_zooms(units='norm'),
+                                  (2000, 2000, 2000, 0.0000025))
+        assert_array_almost_equal(img.header.get_zooms(units='raw'),
+                                  (2, 2, 2, 2.5))
+        assert_equal(img.header.get_xyzt_units(), ('meter', 'usec'))
+
+        # Verify `set_zooms(units=<tuple>)` sets units explicitly
+        img.header.set_zooms((2, 2, 2, 2.5), units=('micron', 'msec'))
+        assert_array_almost_equal(img.header.get_zooms(units='norm'),
+                                  (0.002, 0.002, 0.002, 0.0025))
+        assert_array_almost_equal(img.header.get_zooms(units='raw'),
+                                  (2, 2, 2, 2.5))
+        assert_equal(img.header.get_xyzt_units(), ('micron', 'msec'))
+
+        # Verify `set_zooms(units='norm')` resets units
         img.header.set_zooms((2, 2, 2, 2.5), units='norm')
         assert_array_almost_equal(img.header.get_zooms(units='norm'),
                                   (2, 2, 2, 2.5))
         assert_array_almost_equal(img.header.get_zooms(units='raw'),
                                   (2, 2, 2, 2.5))
         assert_equal(img.header.get_xyzt_units(), ('mm', 'sec'))
 
+        assert_raises(ValueError, img.header.get_zooms, units='badparam')
+        assert_raises(ValueError, img.header.set_zooms, (3, 3, 3, 3.5),
+                      units='badparam')
+
 
 class TestNifti1Image(TestNifti1Pair):
     # Run analyze-flavor spatialimage tests