TEST: Test invalid values for ArrayProxy keep_file_open flag. Add indexed_gzip

to CI build matrix

Author: pauldmccarthy

.travis.yml

@@ -15,6 +15,7 @@ cache:
 env:
     global:
         - DEPENDS="six numpy scipy matplotlib h5py pillow"
+        - OPTIONAL_DEPENDS=""
         - PYDICOM=1
         - INSTALL_TYPE="setup"
         - EXTRA_WHEELS="https://5cf40426d9f06eb7461d-6fe47d9331aba7cd62fc36c7196769e4.ssl.cf2.rackcdn.com"
@@ -84,6 +85,13 @@ matrix:
     - python: 3.5
       env:
         - DOC_DOC_TEST=1
+    # Run tests with indexed_gzip present
+    - python: 2.7
+      env:
+        - OPTIONAL_DEPENDS="indexed_gzip"
+    - python: 3.5
+      env:
+        - OPTIONAL_DEPENDS="indexed_gzip"
 before_install:
     - source tools/travis_tools.sh
     - python -m pip install --upgrade pip
@@ -93,7 +101,7 @@ before_install:
     - python --version # just to check
     - pip install -U pip wheel  # needed at one point
     - retry pip install nose flake8 mock  # always
-    - pip install $EXTRA_PIP_FLAGS $DEPENDS
+    - pip install $EXTRA_PIP_FLAGS $DEPENDS $OPTIONAL_DEPENDS
     # pydicom <= 0.9.8 doesn't install on python 3
     - if [ "${TRAVIS_PYTHON_VERSION:0:1}" == "2" ]; then
         if [ "$PYDICOM" == "1" ]; then

nibabel/tests/test_arrayproxy.py

@@ -345,7 +345,7 @@ def __init__(self, *args, **kwargs):
         CountingImageOpener.numOpeners += 1
 
 
-def test_keep_file_open_true_false():
+def test_keep_file_open_true_false_invalid():
     # Test the behaviour of the keep_file_open __init__ flag, when it is set to
     # True or False.
     CountingImageOpener.numOpeners = 0
@@ -360,7 +360,8 @@ def test_keep_file_open_true_false():
         # handle, and that ArrayProxy(keep_file_open=False) creates a file
         # handle on every data access.
         with mock.patch('nibabel.arrayproxy.ImageOpener', CountingImageOpener):
-            proxy_no_kfp = ArrayProxy(fname, ((10, 10, 10), dtype))
+            proxy_no_kfp = ArrayProxy(fname, ((10, 10, 10), dtype),
+                                      keep_file_open=False)
             assert not proxy_no_kfp._keep_file_open
             for i in range(voxels.shape[0]):
                 x , y, z = [int(c) for c in voxels[i, :]]
@@ -388,13 +389,24 @@ def test_keep_file_open_true_false():
             assert not fobj.closed
             proxy_kfp = ArrayProxy(fobj, ((10, 10, 10), dtype),
                                    keep_file_open=True)
-            assert not proxy_kfp._keep_file_open
+            assert proxy_kfp._keep_file_open
             for i in range(voxels.shape[0]):
                 assert proxy_kfp[x, y, z] == x * 100 + y * 10 + z
                 assert not fobj.closed
             del proxy_kfp
             proxy_kfp = None
             assert not fobj.closed
+        # Test invalid values of keep_file_open
+        with assert_raises(ValueError):
+            ArrayProxy(fname, ((10, 10, 10), dtype), keep_file_open=0)
+        with assert_raises(ValueError):
+            ArrayProxy(fname, ((10, 10, 10), dtype), keep_file_open=1)
+        with assert_raises(ValueError):
+            ArrayProxy(fname, ((10, 10, 10), dtype), keep_file_open=55)
+        with assert_raises(ValueError):
+            ArrayProxy(fname, ((10, 10, 10), dtype), keep_file_open='autob')
+        with assert_raises(ValueError):
+            ArrayProxy(fname, ((10, 10, 10), dtype), keep_file_open='cauto')
 
 
 def test_keep_file_open_default():