Skip to content

Commit 68f4dae

Browse files
committed
Use Params::Get more often
1 parent f116e29 commit 68f4dae

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

lib/Data/Random/String/Matches.pm

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,9 @@ Sets the random seed for reproducible generation
349349
=cut
350350

351351
sub set_seed {
352-
my ($self, $seed) = @_;
352+
my $self = shift;
353+
my $params = Params::Get::get_params('seed', \@_);
354+
my $seed = $params->{'seed'};
353355

354356
croak 'Seed must be defined' unless defined $seed;
355357

@@ -370,9 +372,11 @@ Checks if a string matches the pattern without generating.
370372
=cut
371373

372374
sub validate {
373-
my ($self, $string) = @_;
375+
my $self = shift;
376+
my $params = Params::Get::get_params('string', \@_);
377+
my $string = $params->{'string'};
374378

375-
croak 'String must be defined' unless defined $string;
379+
croak('String must be defined') unless defined $string;
376380

377381
my $regex = $self->{regex};
378382
return $string =~ /^$regex$/;

t/utility_methods.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ subtest 'set_seed - error handling' => sub {
5454
my $gen = Data::Random::String::Matches->new(qr/\d{4}/);
5555

5656
eval { $gen->set_seed() };
57-
like($@, qr/Seed must be defined/, 'Dies without seed');
57+
like($@, qr/Usage/, 'Dies without seed');
5858

5959
eval { $gen->set_seed(undef) };
6060
like($@, qr/Seed must be defined/, 'Dies with undef seed');
@@ -122,7 +122,7 @@ subtest 'validate - error handling' => sub {
122122
my $gen = Data::Random::String::Matches->new(qr/\d{4}/);
123123

124124
eval { $gen->validate() };
125-
like($@, qr/String must be defined/, 'Dies without string');
125+
like($@, qr/Usage/, 'Dies without string');
126126

127127
eval { $gen->validate(undef) };
128128
like($@, qr/String must be defined/, 'Dies with undef');

0 commit comments

Comments
 (0)