minor symfony#28788 invalidate stale commits for PRs too (xabbuh)

fabpot · fabpot · commit 798dcc560dc0 · 2018-10-10T02:30:07.000-07:00
This PR was merged into the 2.8 branch. Discussion ---------- invalidate stale commits for PRs too | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- aee63f5 invalidate stale commits for PRs too
diff --git a/.github/rm-invalid-lowest-lock-files.php b/.github/rm-invalid-lowest-lock-files.php
@@ -104,8 +104,7 @@ function getContentHash(array $composerJson)
     }
 }
 
-if (!$referencedCommits || (isset($_SERVER['TRAVIS_PULL_REQUEST']) && 'false' !== $_SERVER['TRAVIS_PULL_REQUEST'])) {
-    // cached commits cannot be stale for PRs
+if (!$referencedCommits) {
     return;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,7 @@ function getContentHash(array $composerJson)`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`		`-if (!$referencedCommits \|\| (isset($_SERVER['TRAVIS_PULL_REQUEST']) && 'false' !== $_SERVER['TRAVIS_PULL_REQUEST'])) {`
`108`		`- // cached commits cannot be stale for PRs`
	`107`	`+if (!$referencedCommits) {`
`109`	`108`	`return;`
`110`	`109`	`}`
`111`	`110`