GH-3530: Rename the Value column to DataValue to avoid conflicts with reserved words.

Author: David Ellingsworth

src/NHibernate.Test/Async/NHSpecificTest/GH3530/Fixture.cs

@@ -126,7 +126,7 @@ private string GetQualifiedName(string catalog, string schema, string name)
 			{
 				var entity = new U()
 				{
-					Value = expectedValue
+					DataValue = expectedValue
 				};
 
 				id = await (session.SaveAsync(entity, cancellationToken));
@@ -139,7 +139,7 @@ private string GetQualifiedName(string catalog, string schema, string name)
 			{
 				var entity = await (session.GetAsync<U>(id, cancellationToken));
 
-				assert(expectedValue, entity.Value);
+				assert(expectedValue, entity.DataValue);
 			}
 		}
 

src/NHibernate.Test/NHSpecificTest/GH3530/Entities.cs

@@ -14,7 +14,7 @@ public abstract class Entity
 
 	public abstract class Entity<T>:Entity where T : struct
 	{
-		public virtual T Value { get; set; }
+		public virtual T DataValue { get; set; }
 	}
 
 	public class IntegerEntity : Entity<int> { }

src/NHibernate.Test/NHSpecificTest/GH3530/Fixture.cs

@@ -58,7 +58,7 @@ private void CreateTable(string name)
 
 			// Generate columns
 			sb.Append($"Id {guidType}, ");
-			sb.Append($"Value {stringType}");
+			sb.Append($"DataValue {stringType}");
 
 			// Add the primary key contraint for the identity column
 			sb.Append($", {Dialect.PrimaryKeyString} ( Id )");
@@ -114,7 +114,7 @@ private void PerformTest<T, U>(CultureInfo from, CultureInfo to, T expectedValue
 			{
 				var entity = new U()
 				{
-					Value = expectedValue
+					DataValue = expectedValue
 				};
 
 				id = session.Save(entity);
@@ -127,7 +127,7 @@ private void PerformTest<T, U>(CultureInfo from, CultureInfo to, T expectedValue
 			{
 				var entity = session.Get<U>(id);
 
-				assert(expectedValue, entity.Value);
+				assert(expectedValue, entity.DataValue);
 			}
 		}
 

src/NHibernate.Test/NHSpecificTest/GH3530/Mappings.hbm.xml

@@ -3,18 +3,18 @@
                    namespace="NHibernate.Test.NHSpecificTest.GH3530">
   <class name="IntegerEntity">
     <id name="Id" generator="guid.comb" />
-    <property name="Value" column="Value"/>
+    <property name="DataValue" column="DataValue"/>
   </class>
   <class name="DateTimeEntity">
     <id name="Id" generator="guid.comb" />
-    <property name="Value" column="Value"/>
+    <property name="DataValue" column="DataValue"/>
   </class>
   <class name="DoubleEntity">
     <id name="Id" generator="guid.comb" />
-    <property name="Value" column="Value"/>
+    <property name="DataValue" column="DataValue"/>
   </class>
   <class name="DecimalEntity">
     <id name="Id" generator="guid.comb" />
-    <property name="Value" column="Value"/>
+    <property name="DataValue" column="DataValue"/>
   </class>
 </hibernate-mapping>