Log output is 1 character wide in CLion console

[Elemecca]

When running ngscopeclient in JetBrains CLion using the default run configuration created by the CMake project, log output is wrapped to one column:

Turning on the "Emulate terminal in the output console" option in the run configuration fixes it in debug mode but not in run mode (which may just be that option not working in run mode - see the limitations discussed in the linked docs).

I suspect that when terminal emulation is disabled or not working the CLion console doesn't allocate a PTY, so the API to get the window size doesn't work, and we're defaulting to a width of 1 column in that case.

If that guess is correct, then either wrapping should be disabled when the window size is unavailable or the default width should be changed to something more reasonable like 80 columns.

[azonenberg]

That's a fun bug lol.

This is likely an issue in STDLogSink in logtools. On Windows we use GetConsoleScreenBufferInfo(), on Linux we use TIOCGWINSZ. But we don't seem to error check the ioctl so that's probably where things get set wrong.

[Elemecca]

Iiiinteresting. The TIOCGWINSZ call doesn't fail, but all of the members of the output struct are zero. It seems like CLion is allocating a PTY (isatty(STDOUT_FILENO) returns true), but when its terminal emulation is off or unavailable it's just never calling TIOCSWINSZ to tell the kernel how big its window is.

I'll open a PR on logtools to improve the edge-case handling in STDLogSink.

[azonenberg]

Yeah the proper solution here is probably for STDLogSink to detect the ioctl either failing or returning nonsensical (0 or 1) values for terminal width and switching to a plausible default.