Net: work around handling of empty PathAndQuery in http.
#98
+13
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An absolute http::uri::Uri with an empty but set PathAndQuery ("") will
pretend that the path is "/" for comparison, display or HTTP request
construction purposes. However, a relative URI constructed from such
PathAndQuery will be empty.
A directory URI without a path (i.e. "https://example.com") thus
resulted in an empty path in the request line and 400 Bad Request from
the server.
Fixes nginx#97.
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where HTTP requests to directory URIs without a path (e.g., "https://example.com") resulted in 400 Bad Request errors due to an empty request path. The fix extracts and validates the path_and_query before constructing the request URI, ensuring it defaults to "/" when empty or missing.
Key changes:
- Introduced logic to handle empty PathAndQuery by defaulting to "/"
- Refactored URI handling to extract path_and_query earlier and validate it
- Updated http dependency from 1.3.1 to 1.4.0
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/net/http.rs | Refactored URI handling to extract and validate path_and_query before request construction, adding default "/" fallback |
| Cargo.toml | Updated http dependency to version 1.4.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An absolute http::uri::Uri with an empty but set PathAndQuery ("") will pretend that the path is "/" for comparison, display or HTTP request construction purposes. However, a relative URI constructed from such PathAndQuery will be empty.
A directory URI without a path (i.e. "https://example.com") thus resulted in an empty path in the request line and 400 Bad Request from the server.
Fixes #97.