fix: empty adresses with docker internal networks

Co-authored-by: Nicolas Duchon <nicolas.duchon@gmail.com>
Co-authored-by: Anton Tinyakov <anlorn@anlorn.com>

Author: buchdag

internal/context/address.go

@@ -0,0 +1,50 @@
+package context
+
+import (
+	docker "github.com/fsouza/go-dockerclient"
+)
+
+type Address struct {
+	IP           string
+	IP6LinkLocal string
+	IP6Global    string
+	Port         string
+	HostPort     string
+	Proto        string
+	HostIP       string
+}
+
+func renderAddress(container *docker.Container, port docker.Port) Address {
+	return Address{
+		IP:           container.NetworkSettings.IPAddress,
+		IP6LinkLocal: container.NetworkSettings.LinkLocalIPv6Address,
+		IP6Global:    container.NetworkSettings.GlobalIPv6Address,
+		Port:         port.Port(),
+		Proto:        port.Proto(),
+	}
+}
+
+func GetContainerAddresses(container *docker.Container) []Address {
+	addresses := []Address{}
+
+	for port, bindings := range container.NetworkSettings.Ports {
+		address := renderAddress(container, port)
+
+		if len(bindings) > 0 {
+			address.HostPort = bindings[0].HostPort
+			address.HostIP = bindings[0].HostIP
+		}
+
+		addresses = append(addresses, address)
+	}
+
+	if len(addresses) == 0 {
+		// internal docker network has empty 'container.NetworkSettings.Ports'
+		for port := range container.Config.ExposedPorts {
+			address := renderAddress(container, port)
+			addresses = append(addresses, address)
+		}
+	}
+
+	return addresses
+}

internal/context/context.go

@@ -52,16 +52,6 @@ func SetDockerEnv(d *docker.Env) {
 	dockerEnv = d
 }
 
-type Address struct {
-	IP           string
-	IP6LinkLocal string
-	IP6Global    string
-	Port         string
-	HostPort     string
-	Proto        string
-	HostIP       string
-}
-
 type Network struct {
 	IP                  string
 	Name                string

internal/generator/generator.go

@@ -420,22 +420,10 @@ func (g *generator) getContainers() ([]*context.RuntimeContainer, error) {
 			IP6LinkLocal: container.NetworkSettings.LinkLocalIPv6Address,
 			IP6Global:    container.NetworkSettings.GlobalIPv6Address,
 		}
-		for k, v := range container.NetworkSettings.Ports {
-			address := context.Address{
-				IP:           container.NetworkSettings.IPAddress,
-				IP6LinkLocal: container.NetworkSettings.LinkLocalIPv6Address,
-				IP6Global:    container.NetworkSettings.GlobalIPv6Address,
-				Port:         k.Port(),
-				Proto:        k.Proto(),
-			}
-			if len(v) > 0 {
-				address.HostPort = v[0].HostPort
-				address.HostIP = v[0].HostIP
-			}
-			runtimeContainer.Addresses = append(runtimeContainer.Addresses,
-				address)
 
-		}
+		adresses := context.GetContainerAddresses(container)
+		runtimeContainer.Addresses = append(runtimeContainer.Addresses, adresses...)
+
 		for k, v := range container.NetworkSettings.Networks {
 			network := context.Network{
 				IP:                  v.IPAddress,
@@ -453,6 +441,7 @@ func (g *generator) getContainers() ([]*context.RuntimeContainer, error) {
 			runtimeContainer.Networks = append(runtimeContainer.Networks,
 				network)
 		}
+
 		for k, v := range container.Volumes {
 			runtimeContainer.Volumes[k] = context.Volume{
 				Path:      k,