Skip to content

Github CI is not useful for external contributors #16212

@PhilLab

Description

@PhilLab

As I am not an expert with Github CI (I am more familiar with Gitlab), parts of these might be Github's fault, but nonetheless - the CI is not doing any favor to external contributors. IMHO, it should support them better, to motivate more outside contributions

  1. Email flood

    • After a lot of quiet on the PR, I am suddenly bombarded with ~13 emails about failing jobs. Especially if I have multiple PRs open, it is quite hard to keep track of what is affected
    • Any chance of having one email per PR instead, reporting the CI failure once, per PR?
    • Image
  2. It is unclear when the CI runs and where

    • We should explain in the CONTRIBUTING.md that most jobs (but not all, I think?) run only when a maintainer starts them
    • There is also a Drone CI running somewhere?
    • It is unclear where I see my newly added tests actually running
    • I tried to get to the bottom of this here, but didn't get far: Minor improvements for automated testing #15424 (comment)
  3. Some jobs simply fail by design, when it is on a fork

  4. It is unclear what checks should be run locally, to ensure a smooth CI experience

  5. Details of a CI failure are hard to understand

  6. Said linter job just always fails, unrelated to the changes in the PR

  7. The detectWrongSettings job is destined to fail

    • Because the maintainer triggering of the CI job is happening weeks later than the original PR, at time of triggering the PR is almost always out-of-date, so it doesn't use one of the latest 10 android-library commits.
    • This issue is fixable by the contributor, by rebasing, but it does cause additional friction as well (yet another failure, yet another alert, ...)

cc @AndyScherzinger

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions