Skip to content

Commit fbdff9d

Browse files
committed
Cleaned up IDE hints on Bolt/Bolt3 classes
1 parent acdf0af commit fbdff9d

File tree

2 files changed

+20
-16
lines changed

2 files changed

+20
-16
lines changed

neo4j/io/__init__.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151

5252
from ssl import (
5353
HAS_SNI,
54-
SSLSocket,
5554
SSLError,
5655
)
5756

@@ -134,31 +133,25 @@ def open(cls, address, *, auth=None, timeout=None, **config):
134133
connection.hello()
135134
return connection
136135

137-
def __init__(self, unresolved_address, sock, *, auth=None, **config):
138-
raise NotImplementedError
139-
140136
@property
141137
def secure(self):
142-
return isinstance(self.socket, SSLSocket)
138+
raise NotImplementedError
143139

144140
@property
145141
def der_encoded_server_certificate(self):
146-
return self.socket.getpeercert(binary_form=True)
142+
raise NotImplementedError
147143

148144
@property
149145
def local_port(self):
150-
try:
151-
return self.socket.getsockname()[1]
152-
except IOError:
153-
return 0
146+
raise NotImplementedError
154147

155148
def hello(self):
156149
raise NotImplementedError
157150

158151
def __del__(self):
159152
try:
160153
self.close()
161-
except:
154+
except OSError:
162155
pass
163156

164157
def __enter__(self):

neo4j/io/_bolt3.py

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,11 @@
2020

2121
from collections import deque
2222
from select import select
23+
from ssl import SSLSocket
2324
from struct import pack as struct_pack
2425
from time import perf_counter
2526
from neo4j.api import (
26-
Bookmark,
2727
Version,
28-
ServerInfo,
2928
)
3029
from neo4j.meta import get_user_agent
3130
from neo4j.exceptions import (
@@ -37,10 +36,7 @@
3736
NotALeaderError,
3837
ForbiddenOnReadOnlyDatabaseError,
3938
IncompleteCommitError,
40-
SecurityError,
41-
ClientError,
4239
SessionExpired,
43-
TransactionError,
4440
)
4541
from neo4j.packstream import (
4642
UnpackableBuffer,
@@ -119,6 +115,21 @@ def __init__(self, unresolved_address, sock, *, auth=None, **config):
119115
if credentials is None:
120116
raise AuthError("Password cannot be None")
121117

118+
@property
119+
def secure(self):
120+
return isinstance(self.socket, SSLSocket)
121+
122+
@property
123+
def der_encoded_server_certificate(self):
124+
return self.socket.getpeercert(binary_form=True)
125+
126+
@property
127+
def local_port(self):
128+
try:
129+
return self.socket.getsockname()[1]
130+
except IOError:
131+
return 0
132+
122133
def hello(self):
123134
headers = {"user_agent": self.user_agent}
124135
headers.update(self.auth_dict)

0 commit comments

Comments
 (0)