Fixed Address constructor returning same instance

Author: technige

neo4j/addressing.py

@@ -70,8 +70,8 @@ def parse_list(cls, *s, default_host=None, default_port=None):
                 for a in " ".join(s).split()]
 
     def __new__(cls, iterable):
-        if type(iterable) is cls:
-            return cls
+        if isinstance(iterable, cls):
+            return iterable
         n_parts = len(iterable)
         inst = tuple.__new__(cls, iterable)
         if n_parts == 2:

tests/unit/test_addressing.py

@@ -55,3 +55,9 @@ def test_should_error_when_value_missing(self):
     def test_should_error_when_key_duplicate(self):
         with self.assertRaises(ValueError):
             GraphDatabase._parse_routing_context("name=molly&name=white")
+
+
+def test_address_init_with_address_object_returns_same_instance():
+    a = Address(("localhost", 7687))
+    b = Address(a)
+    assert id(a) == id(b)