Merge pull request #484 from ali-ince/4.0-fix-notification-tests

Use another statement for cypher notification tests

Author: ali-ince

test/rx/summary.test.js

@@ -560,27 +560,25 @@ describe('#integration-rx summary', () => {
    * @param {RxSession|RxTransaction} runnable
    */
   async function shouldReturnNotification (version, runnable) {
-    pending('seems to be flaky')
-
     if (version.compareTo(VERSION_4_0_0) < 0) {
       return
     }
 
     const summary = await runnable
-      .run('CYPHER runtime=interpreted EXPLAIN MATCH (n),(m) RETURN n,m')
+      .run('EXPLAIN MATCH (n:ThisLabelDoesNotExist) RETURN n')
       .summary()
       .toPromise()
     expect(summary).toBeDefined()
     expect(summary.notifications).toBeTruthy()
     expect(summary.notifications.length).toBeGreaterThan(0)
     expect(summary.notifications[0].code).toBe(
-      'Neo.ClientNotification.Statement.CartesianProductWarning'
+      'Neo.ClientNotification.Statement.UnknownLabelWarning'
     )
     expect(summary.notifications[0].title).toBe(
-      'This query builds a cartesian product between disconnected patterns.'
+      'The provided label is not in the database.'
     )
     expect(summary.notifications[0].description).toBe(
-      'If a part of a query contains multiple disconnected patterns, this will build a cartesian product between all those parts. This may produce a large amount of data and slow down query processing. While occasionally intended, it may often be possible to reformulate the query that avoids the use of this cross product, perhaps by adding a relationship between the different parts or by using OPTIONAL MATCH (identifier is: (m))'
+      'One of the labels in your query is not available in the database, make sure you didn\'t misspell it or that the label is available when you run this statement in your application (the missing label name is: ThisLabelDoesNotExist)'
     )
     expect(summary.notifications[0].severity).toBe('WARNING')
   }

test/session.test.js

@@ -304,21 +304,17 @@ describe('#integration session', () => {
   })
 
   it('should expose cypher notifications ', done => {
-    if (serverVersion.compareTo(VERSION_4_0_0) >= 0) {
-      pending('seems to be flaky')
-    }
-
     // Given
-    const statement = 'EXPLAIN MATCH (n), (m) RETURN n, m'
+    const statement = 'EXPLAIN MATCH (n:ThisLabelDoesNotExist) RETURN n'
     // When & Then
     session.run(statement).then(result => {
       const sum = result.summary
       expect(sum.notifications.length).toBeGreaterThan(0)
       expect(sum.notifications[0].code).toBe(
-        'Neo.ClientNotification.Statement.CartesianProductWarning'
+        'Neo.ClientNotification.Statement.UnknownLabelWarning'
       )
       expect(sum.notifications[0].title).toBe(
-        'This query builds a cartesian product between disconnected patterns.'
+        'The provided label is not in the database.'
       )
       expect(sum.notifications[0].position.column).toBeGreaterThan(0)
       done()
@@ -1314,9 +1310,7 @@ describe('#integration session', () => {
       .run('RETURN $value', { value: value })
       .then(() => {
         done.fail(
-          `Should not be possible to send ${
-            value.constructor.name
-          } ${value} as a query parameter`
+          `Should not be possible to send ${value.constructor.name} ${value} as a query parameter`
         )
       })
       .catch(error => {

test/summary.test.js

@@ -48,7 +48,11 @@ describe('#integration result summary', () => {
     })
 
     it('should get notifications from summary', done => {
-      verifyNotifications(session, 'EXPLAIN MATCH (n), (m) RETURN n, m', done)
+      verifyNotifications(
+        session,
+        'EXPLAIN MATCH (n:ThisLabelDoesNotExist) RETURN n',
+        done
+      )
     })
   })
 
@@ -81,7 +85,11 @@ describe('#integration result summary', () => {
     })
 
     it('should get notifications from summary', done => {
-      verifyNotifications(session, 'EXPLAIN MATCH (n), (m) RETURN n, m', done)
+      verifyNotifications(
+        session,
+        'EXPLAIN MATCH (n:ThisLabelDoesNotExist) RETURN n',
+        done
+      )
     })
   })