Rename Connection#sync() to #flush()

Later better describes the logic of the function. There is no sync
operation, only flushing of the queued messages/chunks. Responses
arrive asynchronously are de-chunked and forwarded for the
corresponding observers.

Author: lutovich

src/v1/internal/connector.js

@@ -278,7 +278,7 @@ class Connection {
       this._packer.packStruct(INIT, [this._packable(clientName), this._packable(token)],
         (err) => this._handleFatalError(err));
       this._chunker.messageBoundary();
-      this.sync();
+      this.flush();
     }
   }
 
@@ -321,7 +321,7 @@ class Connection {
 
   /**
    * Send a RESET-message to the database. Mutes failure handling.
-   * Message is immediately flushed to the network. Separate {@link Connection#sync()} call is not required.
+   * Message is immediately flushed to the network. Separate {@link Connection#flush()} call is not required.
    * @return {Promise<void>} promise resolved when SUCCESS-message response arrives, or failed when other response messages arrives.
    */
   resetAndFlush() {
@@ -371,7 +371,7 @@ class Connection {
     if (queued) {
       this._packer.packStruct(RESET, [], err => this._handleFatalError(err));
       this._chunker.messageBoundary();
-      this.sync();
+      this.flush();
     }
   }
 
@@ -412,10 +412,9 @@ class Connection {
   }
 
   /**
-   * Synchronize - flush all queued outgoing messages and route their responses
-   * to their respective handlers.
+   * Flush all queued outgoing messages.
    */
-  sync() {
+  flush() {
     this._chunker.flush();
   }
 

src/v1/session.js

@@ -75,7 +75,7 @@ class Session {
       connectionHolder.getConnection(streamObserver).then(connection => {
         statementRunner(connection, streamObserver);
         connection.pullAll(streamObserver);
-        connection.sync();
+        connection.flush();
       }).catch(error => streamObserver.onError(error));
     } else {
       streamObserver.onError(newError('Statements cannot be run directly on a ' +

src/v1/transaction.js

@@ -162,7 +162,7 @@ let _states = {
       connectionHolder.getConnection(observer).then(conn => {
         conn.run(statement, parameters || {}, observer);
         conn.pullAll(observer);
-        conn.sync();
+        conn.flush();
       }).catch(error => observer.onError(error));
 
       return _newRunResult(observer, statement, parameters, () => observer.serverMetadata());
@@ -240,7 +240,7 @@ function _runPullAll(msg, connectionHolder, observer) {
   connectionHolder.getConnection(observer).then(conn => {
     conn.run(msg, {}, observer);
     conn.pullAll(observer);
-    conn.sync();
+    conn.flush();
   }).catch(error => observer.onError(error));
 
   // for commit & rollback we need result that uses real connection holder and notifies it when

test/internal/connector.test.js

@@ -73,7 +73,7 @@ describe('connector', () => {
       },
       onError: console.log
     });
-    connection.sync();
+    connection.flush();
 
   });
 
@@ -94,7 +94,7 @@ describe('connector', () => {
         done();
       }
     });
-    connection.sync();
+    connection.flush();
   });
 
   it('should use DummyChannel to read what gets written', done => {
@@ -113,7 +113,7 @@ describe('connector', () => {
     // When
     connection.initialize('mydriver/0.0.0', basicAuthToken());
     connection.run('RETURN 1', {});
-    connection.sync();
+    connection.flush();
     expect(observer.instance.toHex()).toBe('00 44 b2 01 8e 6d 79 64 72 69 76 65 72 2f 30 2e 30 2e 30 a3 86 73 63 68 65 6d 65 85 62 61 73 69 63 89 70 72 69 6e 63 69 70 61 6c 85 6e 65 6f 34 6a 8b 63 72 65 64 65 6e 74 69 61 6c 73 88 70 61 73 73 77 6f 72 64 00 00 00 0c b2 10 88 52 45 54 55 52 4e 20 31 a0 00 00 ');
     done();
   });
@@ -135,7 +135,7 @@ describe('connector', () => {
         done();
       }
     });
-    connection.sync();
+    connection.flush();
 
   });
 

test/internal/fake-connection.js

@@ -31,7 +31,7 @@ export default class FakeConnection {
     this.creationTimestamp = Date.now();
 
     this.resetInvoked = 0;
-    this.syncInvoked = 0;
+    this.flushInvoked = 0;
     this.releaseInvoked = 0;
     this.initializationInvoked = 0;
     this.seenStatements = [];
@@ -58,8 +58,8 @@ export default class FakeConnection {
     return Promise.resolve();
   }
 
-  sync() {
-    this.syncInvoked++;
+  flush() {
+    this.flushInvoked++;
   }
 
   _release() {