fix(dialogs): AlertDialog hide is now async to allow to wait for dialog to be hidden

Especially useful on iOS to prevent errors like “already transitioning”

Author: farfromrefug

src/dialogs/dialogs.android.ts

@@ -296,18 +296,29 @@ export function alert(arg: any): Promise<void> {
 export class AlertDialog {
     dialog: androidx.appcompat.app.AlertDialog;
     constructor(private options: any) {}
-    show(resolve?) {
+    onCloseListeners: any[] = [];
+    onClosed() {
+        this.onCloseListeners.forEach((l) => l());
+        this.onCloseListeners = [];
+    }
+    show(onClosed?) {
         if (!this.dialog) {
             const alert = createAlertDialogBuilder(this.options);
             this.dialog = alert.create();
-            this.dialog = prepareAndCreateAlertDialog(alert, this.options, resolve);
+            this.dialog = prepareAndCreateAlertDialog(alert, this.options, () => {
+                this.onClosed();
+                onClosed?.();
+            });
             showDialog(this.dialog, this.options);
         }
     }
-    hide() {
+    async hide() {
         if (this.dialog) {
-            this.dialog.cancel();
-            this.dialog = null;
+            return new Promise((resolve) => {
+                this.onCloseListeners.push(resolve);
+                this.dialog.cancel();
+                this.dialog = null;
+            });
         }
     }
 }

src/dialogs/dialogs.d.ts

@@ -124,5 +124,5 @@ export function action(options: ActionOptions & MDCAlertControlerOptions): Promi
 export class AlertDialog {
     constructor(options: AlertOptions & MDCAlertControlerOptions);
     show(resolve?);
-    hide();
+    async hide();
 }

src/dialogs/dialogs.ios.ts

@@ -174,8 +174,8 @@ function createAlertController(options: DialogOptions & MDCAlertControlerOptions
             options.view instanceof View
                 ? options.view
                 : Builder.createViewFromEntry({
-                    moduleName: options.view as string
-                });
+                      moduleName: options.view as string
+                  });
 
         view.cssClasses.add(CSSUtils.MODAL_ROOT_VIEW_CSS_CLASS);
         const modalRootViewCssClasses = CSSUtils.getSystemCssClasses();
@@ -246,17 +246,20 @@ export class AlertDialog {
     alertController: MDCAlertController;
     presentingController: UIViewController;
     constructor(private options: any) {}
-    show(resolve?) {
+
+    show(onClosed?) {
         if (!this.alertController) {
-            this.alertController = createAlertController(this.options, resolve);
+            this.alertController = createAlertController(this.options, onClosed);
             this.presentingController = showUIAlertController(this.alertController, this.options);
         }
     }
-    hide() {
+    async hide() {
         if (this.presentingController) {
-            this.presentingController.dismissViewControllerAnimatedCompletion(true, null);
-            this.presentingController = null;
-            this.alertController = null;
+            return new Promise<void>((resolve) => {
+                this.presentingController.dismissViewControllerAnimatedCompletion(true, resolve);
+                this.presentingController = null;
+                this.alertController = null;
+            });
         }
     }
 }
@@ -271,8 +274,8 @@ export function confirm(arg: any): Promise<boolean> {
             };
             const options = !isDialogOptions(arg)
                 ? Object.assign(defaultOptions, {
-                    message: arg + ''
-                })
+                      message: arg + ''
+                  })
                 : Object.assign(defaultOptions, arg);
             const alertController = createAlertController(options, resolve);