chore: {N} 8 and eslint

NathanWalker · NathanWalker · commit 51c10d883835 · 2021-03-27T13:34:16.000-07:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,13 +1,16 @@
 module.exports = {
     extends: ['plugin:prettier/recommended'],
-    plugins: ['prettier', '@typescript-eslint'],
+    plugins: ['prettier', '@typescript-eslint', '@nativescript'],
     parser: '@typescript-eslint/parser',
     parserOptions: {
         createDefaultProgram: true,
         project: './tsconfig.json'
     },
     rules: {
         'prettier/prettier': 'warn',
+        "@nativescript/no-nativescript-angular-imports": "warn",
+        "@nativescript/no-tns-core-modules-imports": "warn",
+        "@nativescript/no-duplicate-ns-imports": "warn",
         '@typescript-eslint/adjacent-overload-signatures': 'error',
         '@typescript-eslint/array-type': 'error',
         '@typescript-eslint/await-thenable': 'error',
diff --git a/demo-ng/package.json b/demo-ng/package.json
@@ -1,16 +1,16 @@
 {
     "description": "NativeScript Application",
     "dependencies": {
-        "@angular/animations": "~10.1.3",
-        "@angular/common": "~10.1.3",
-        "@angular/compiler": "~10.1.3",
-        "@angular/core": "~10.1.3",
-        "@angular/forms": "~10.1.3",
-        "@angular/platform-browser": "~10.1.3",
-        "@angular/platform-browser-dynamic": "~10.1.3",
-        "@angular/router": "~10.1.3",
-        "@nativescript/core": "~7.0.7",
-        "@nativescript/angular": "~10.1.5",
+        "@angular/animations": "~11.2.0",
+        "@angular/common": "~11.2.0",
+        "@angular/compiler": "~11.2.0",
+        "@angular/core": "~11.2.0",
+        "@angular/forms": "~11.2.0",
+        "@angular/platform-browser": "~11.2.0",
+        "@angular/platform-browser-dynamic": "~11.2.0",
+        "@angular/router": "~11.2.0",
+        "@nativescript/core": "8.0.0-alpha.2",
+        "@nativescript/angular": "~11.0.0",
         "@nativescript-community/ui-material-activityindicator": "file:../packages/activityindicator",
         "@nativescript-community/ui-material-bottomsheet": "file:../packages/bottomsheet",
         "@nativescript-community/ui-material-bottomnavigationbar": "file:../packages/bottomnavigationbar",
@@ -28,16 +28,16 @@
         "@nativescript/theme": "~3.0.0",
         "reflect-metadata": "~0.1.13",
         "rxjs": "~6.6.3",
-        "zone.js": "~0.10.2"
+        "zone.js": "~0.11.0"
     },
     "devDependencies": {
-        "@angular/cli": "~10.1.3",
-        "@angular/compiler-cli": "~10.1.3",
-        "@nativescript/android": "7.0.0",
-        "@nativescript/ios": "7.0.0",
-        "@nativescript/types": "~7.0.4",
+        "@angular/cli": "~11.2.0",
+        "@angular/compiler-cli": "~11.2.0",
+        "@nativescript/android": "7.0.1",
+        "@nativescript/ios": "7.2.0",
+        "@nativescript/types": "~7.3.0",
         "@nativescript/webpack": "~4.1.0",
-        "@ngtools/webpack": "10.1.3"
+        "@ngtools/webpack": "~11.2.0"
     },
     "gitHead": "8ab7726d1ee9991706069c1359c552e67ee0d1a4",
     "readme": "NativeScript Application"
diff --git a/demo-svelte/package.json b/demo-svelte/package.json
@@ -29,7 +29,7 @@
   "dependencies": {
     "@nativescript-community/ui-material-button": "file:../packages/button",
     "@nativescript-community/ui-material-speeddial": "file:../packages/speeddial",
-    "@nativescript/core": "~7.0.0",
+    "@nativescript/core": "8.0.0-alpha.2",
     "@nativescript/theme": "~2.3.0",
     "svelte-native": "~0.9.4"
   },
diff --git a/demo-vue/package.json b/demo-vue/package.json
@@ -5,7 +5,7 @@
     "repository": "http://www.github.com/NativeScript/nativescript-ui-sidedrawer.git",
     "dependencies": {
         "@mdi/font": "4.9.95",
-        "@nativescript/core": "7.3.0",
+        "@nativescript/core": "8.0.0-alpha.2",
         "@nativescript-community/text": "1.4.9",
         "@nativescript-community/ui-material-activityindicator": "file:../packages/activityindicator",
         "@nativescript-community/ui-material-bottom-navigation": "file:../packages/bottom-navigation",
diff --git a/demo/package.json b/demo/package.json
@@ -1,6 +1,6 @@
 {
     "dependencies": {
-        "@nativescript/core": "rc",
+        "@nativescript/core": "8.0.0-alpha.2",
         "@nativescript-community/ui-material-activityindicator": "file:../packages/activityindicator",
         "@nativescript-community/ui-material-bottomsheet": "file:../packages/bottomsheet",
         "@nativescript-community/ui-material-bottomnavigationbar": "file:../packages/bottomnavigationbar",
diff --git a/package.json b/package.json
@@ -46,23 +46,24 @@
     "repository": "https://github.com/nativescript-community/ui-material-components",
     "readmeFilename": "README.md",
     "devDependencies": {
-        "@angular/animations": "~10.1.4",
-        "@angular/common": "~10.1.4",
-        "@angular/compiler": "~10.1.4",
-        "@angular/compiler-cli": "~10.1.4",
-        "@angular/core": "~10.1.4",
-        "@angular/forms": "~10.1.4",
-        "@angular/platform-browser": "~10.1.4",
-        "@angular/platform-browser-dynamic": "~10.1.4",
-        "@angular/router": "~10.1.4",
+        "@angular/animations": "~11.2.0",
+        "@angular/common": "~11.2.0",
+        "@angular/compiler": "~11.2.0",
+        "@angular/compiler-cli": "~11.2.0",
+        "@angular/core": "~11.2.0",
+        "@angular/forms": "~11.2.0",
+        "@angular/platform-browser": "~11.2.0",
+        "@angular/platform-browser-dynamic": "~11.2.0",
+        "@angular/router": "~11.2.0",
         "@commitlint/cli": "^12.0.1",
         "@commitlint/config-conventional": "^12.0.1",
         "@nativescript-community/text": "^1.4.9",
-        "@nativescript/angular": "~10.1.7",
-        "@nativescript/core": "7.3.0",
+        "@nativescript/angular": "~11.0.0",
+        "@nativescript/core": "8.0.0-alpha.2",
+        "@nativescript/eslint-plugin": "0.0.1",
         "@nativescript/hook": "~2.0.0",
-        "@nativescript/types": "7.3.0",
-        "@nativescript/webpack": "~4.1.0",
+        "@nativescript/types": "7.2.0",
+        "@nativescript/webpack": "~4.0.1",
         "@types/node": "~14.14.35",
         "@typescript-eslint/eslint-plugin": "4.18.0",
         "@typescript-eslint/parser": "4.18.0",
@@ -74,16 +75,16 @@
         "globby": "^11.0.3",
         "husky": "^4.3.8",
         "lerna": "^4.0.0",
-        "nativescript": "7.0.11",
+        "nativescript": "7.2.1",
         "nativescript-vue": "~2.8.4",
-        "ng-packagr": "~10.1.0",
+        "ng-packagr": "~11.2.0",
         "prettier": "^2.2.1",
         "prompt": "^1.1.0",
         "rimraf": "^3.0.2",
         "rxjs": "^6.6.6",
         "ts-patch": "^1.3.2",
         "typedoc": "^0.20.33",
-        "typescript": "~3.9.7",
+        "typescript": "~4.0.0",
         "vue": "2.6.12"
     },
     "commitlint": {
diff --git a/src/bottom-navigation/index.android.ts b/src/bottom-navigation/index.android.ts
@@ -4,8 +4,8 @@ import { TabStrip } from '@nativescript-community/ui-material-core/tab-navigatio
 import { TabStripItem } from '@nativescript-community/ui-material-core/tab-navigation-base/tab-strip-item';
 // Types
 // Requires
-import { Application, CSSType, Color, Font, Frame, ImageSource, Utils, View, getIconSpecSize } from '@nativescript/core';
-import { TextTransform, getTransformedText } from '@nativescript/core/ui/text-base';
+import { Application, CSSType, Color, Font, Frame, ImageSource, Utils, View, getIconSpecSize, Enums } from '@nativescript/core';
+import { getTransformedText } from '@nativescript/core/ui/text-base';
 export { TabContentItem, TabStrip, TabStripItem };
 
 // TODO: Impl trace
@@ -249,7 +249,7 @@ export class BottomNavigation extends TabNavigationBase {
     private _currentTransaction: androidx.fragment.app.FragmentTransaction;
     private _attachedToWindow = false;
     public _originalBackground: any;
-    private _textTransform: TextTransform = 'none';
+    private _textTransform: Enums.TextTransformType = 'none';
     private _selectedItemColor: Color;
     private _unSelectedItemColor: Color;
 
@@ -675,9 +675,9 @@ export class BottomNavigation extends TabNavigationBase {
         });
     }
 
-    private getItemLabelTextTransform(tabStripItem: TabStripItem): TextTransform {
+    private getItemLabelTextTransform(tabStripItem: TabStripItem): Enums.TextTransformType {
         const nestedLabel = tabStripItem.label;
-        let textTransform: TextTransform = null;
+        let textTransform: Enums.TextTransformType = null;
         if (nestedLabel && nestedLabel.style.textTransform !== 'initial') {
             textTransform = nestedLabel.style.textTransform;
         } else if (tabStripItem.style.textTransform !== 'initial') {
@@ -924,17 +924,17 @@ export class BottomNavigation extends TabNavigationBase {
         tabStripItem.nativeViewProtected.setTypeface(value.getAndroidTypeface());
     }
 
-    public setTabBarItemTextTransform(tabStripItem: TabStripItem, value: TextTransform): void {
+    public setTabBarItemTextTransform(tabStripItem: TabStripItem, value: Enums.TextTransformType): void {
         const titleLabel = tabStripItem.label;
         const title = getTransformedText(titleLabel.text, value);
         tabStripItem.nativeViewProtected.setText(title);
     }
 
-    public getTabBarTextTransform(): TextTransform {
+    public getTabBarTextTransform(): Enums.TextTransformType {
         return this._textTransform;
     }
 
-    public setTabBarTextTransform(value: TextTransform): void {
+    public setTabBarTextTransform(value: Enums.TextTransformType): void {
         const items = this.tabStrip && this.tabStrip.items;
         if (items) {
             items.forEach((tabStripItem) => {
diff --git a/src/bottom-navigation/index.ios.ts b/src/bottom-navigation/index.ios.ts
@@ -5,8 +5,8 @@ import { TabStrip } from '@nativescript-community/ui-material-core/tab-navigatio
 import { TabStripItem } from '@nativescript-community/ui-material-core/tab-navigation-base/tab-strip-item';
 // Types
 // Requires
-import { CSSType, Color, Device, Font, Frame, IOSHelper, ImageSource, Property, Utils, View, booleanConverter, getIconSpecSize } from '@nativescript/core';
-import { TextTransform, getTransformedText } from '@nativescript/core/ui/text-base';
+import { CSSType, Color, Device, Font, Frame, IOSHelper, ImageSource, Property, Utils, View, booleanConverter, getIconSpecSize, Enums } from '@nativescript/core';
+import { getTransformedText } from '@nativescript/core/ui/text-base';
 import { iOSNativeHelper } from '@nativescript/core/utils';
 export { TabContentItem, TabStrip, TabStripItem };
 
@@ -440,7 +440,7 @@ export class BottomNavigation extends TabNavigationBase {
         this.setViewAttributes(tabStripItem.nativeView, tabStripItem.label);
     }
 
-    public setTabBarItemTextTransform(tabStripItem: TabStripItem, value: TextTransform): void {
+    public setTabBarItemTextTransform(tabStripItem: TabStripItem, value: Enums.TextTransformType): void {
         tabStripItem.nativeView.title = getTransformedText(tabStripItem.label.text, value);
     }
 
diff --git a/src/button/button.android.ts b/src/button/button.android.ts
@@ -12,9 +12,10 @@ import {
     androidElevationProperty,
     backgroundInternalProperty,
     colorProperty,
-    profile
+    profile,
+    Enums
 } from '@nativescript/core';
-import { TextAlignment, TextTransform, textAlignmentProperty, textTransformProperty } from '@nativescript/core/ui/text-base';
+import { textAlignmentProperty, textTransformProperty } from '@nativescript/core/ui/text-base';
 import { ButtonBase, imageSourceProperty, srcProperty } from './button-common';
 
 let LayoutInflater: typeof android.view.LayoutInflater;
@@ -140,7 +141,7 @@ export class Button extends ButtonBase {
     setStrokeWidth(value) {
         this.nativeViewProtected.setStrokeWidth(value);
     }
-    [textTransformProperty.setNative](value: TextTransform) {
+    [textTransformProperty.setNative](value: Enums.TextTransformType) {
         this.nativeViewProtected.setAllCaps(value !== 'none');
     }
     [backgroundInternalProperty.getDefault]() {
@@ -168,7 +169,7 @@ export class Button extends ButtonBase {
         }
     }
 
-    [textAlignmentProperty.setNative](value: TextAlignment) {
+    [textAlignmentProperty.setNative](value: Enums.TextAlignmentType) {
         this.nativeTextViewProtected.setGravity(getHorizontalGravity(value) | getVerticalGravity(this.verticalTextAlignment));
     }
     [verticalTextAlignmentProperty.setNative](value: VerticalTextAlignment) {
diff --git a/src/button/button.ios.ts b/src/button/button.ios.ts
@@ -13,8 +13,9 @@ import {
     borderTopRightRadiusProperty,
     colorProperty,
     fontInternalProperty,
+    Enums,
 } from '@nativescript/core';
-import { TextTransform, textTransformProperty } from '@nativescript/core/ui/text-base';
+import { textTransformProperty } from '@nativescript/core/ui/text-base';
 import { ButtonBase, imageSourceProperty, srcProperty } from './button-common';
 
 let buttonScheme: MDCContainerScheme;
@@ -220,7 +221,7 @@ export class Button extends ButtonBase {
         }
     }
 
-    [textTransformProperty.setNative](value: TextTransform) {
+    [textTransformProperty.setNative](value: Enums.TextTransformType) {
         this.nativeViewProtected.uppercaseTitle = value !== 'none';
     }
     [rippleColorProperty.setNative](color: Color) {
diff --git a/src/core/android/utils.ts b/src/core/android/utils.ts
@@ -1,6 +1,5 @@
 import { VerticalTextAlignment } from '@nativescript-community/text';
-import { Application, Color, Utils, ViewBase, profile } from '@nativescript/core';
-import { TextAlignment } from '@nativescript/core/ui/text-base';
+import { Application, Color, Utils, ViewBase, profile, Enums } from '@nativescript/core';
 
 let isPostLollipopVar: boolean;
 export function isPostLollipop() {
@@ -250,7 +249,7 @@ export function getAttr(context: android.content.Context, id: string) {
     return context.getResources().getIdentifier(id, 'attr', context.getPackageName());
 }
 
-export function getHorizontalGravity(textAlignment: TextAlignment) {
+export function getHorizontalGravity(textAlignment: Enums.TextAlignmentType) {
     switch (textAlignment) {
         case 'initial':
         case 'left':
diff --git a/src/core/cssproperties.ts b/src/core/cssproperties.ts
@@ -1,4 +1,4 @@
-import { Color, CssProperty, InheritedCssProperty, Length, Style, makeParser, makeValidator } from '@nativescript/core';
+import { Color, CssProperty, InheritedCssProperty, Length, Style, makeParser, makeValidator, LengthType } from '@nativescript/core';
 
 function createGetter(key) {
     return function () {
@@ -27,14 +27,14 @@ export const rippleColorProperty = new CssProperty<Style, Color>({
     valueConverter: (v) => new Color(v)
 });
 rippleColorProperty.register(Style);
-export const elevationProperty = new CssProperty<Style, Length>({
+export const elevationProperty = new CssProperty<Style, LengthType>({
     name: 'elevation',
     cssName: 'elevation',
 
     valueConverter: parseFloat
 });
 elevationProperty.register(Style);
-export const dynamicElevationOffsetProperty = new CssProperty<Style, Length>({
+export const dynamicElevationOffsetProperty = new CssProperty<Style, LengthType>({
     name: 'dynamicElevationOffset',
     cssName: 'dynamic-elevation-offset',
 
diff --git a/src/core/tab-navigation-base/tab-strip-item/index.ts b/src/core/tab-navigation-base/tab-strip-item/index.ts
@@ -1,9 +1,9 @@
-﻿/**
+/**
  * @module @nativescript-community/ui-material-core/tab-navigation-base/tab-strip-item
 */
-import { AddChildFromBuilder, CSSType, Color, Image, Label, PropertyChangeData, PseudoClassHandler, View, ViewBase } from '@nativescript/core';
+import { AddChildFromBuilder, CSSType, Color, Image, Label, PropertyChangeData, PseudoClassHandler, View, ViewBase, Enums } from '@nativescript/core';
 import { backgroundColorProperty, backgroundInternalProperty } from '@nativescript/core/ui/styling/style-properties';
-import { TextTransform, textTransformProperty } from '@nativescript/core/ui/text-base';
+import { textTransformProperty } from '@nativescript/core/ui/text-base';
 import { TabStripItem as TabStripItemDefinition } from '.';
 import { TabNavigationBase } from '../tab-navigation-base';
 import { TabStrip } from '../tab-strip';
@@ -264,13 +264,13 @@ export class TabStripItem extends View implements TabStripItemDefinition, AddChi
         return tabStripParent && tabStripParent.setTabBarItemBackgroundColor(this, value);
     }
 
-    [textTransformProperty.getDefault](): TextTransform {
+    [textTransformProperty.getDefault](): Enums.TextTransformType {
         const parent = this.parent as TabStrip;
         const tabStripParent = parent && parent.parent as TabNavigationBase;
 
         return tabStripParent && tabStripParent.getTabBarItemTextTransform(this);
     }
-    [textTransformProperty.setNative](value: TextTransform) {
+    [textTransformProperty.setNative](value: Enums.TextTransformType) {
         const parent = this.parent as TabStrip;
         const tabStripParent = parent && parent.parent as TabNavigationBase;
 
diff --git a/src/progress/progress.android.ts b/src/progress/progress.android.ts
@@ -1,6 +1,5 @@
 import { themer } from '@nativescript-community/ui-material-core';
-import { Color, PercentLength, colorProperty, heightProperty, visibilityProperty } from '@nativescript/core';
-import { Visibility } from '@nativescript/core/ui/enums';
+import { Color, PercentLength, heightProperty } from '@nativescript/core';
 import { ProgressBase, busyProperty, indeterminateProperty, progressBackgroundColorProperty, progressColorProperty } from './progress-common';
 
 export class Progress extends ProgressBase {
diff --git a/src/tabs/tabs.android.ts b/src/tabs/tabs.android.ts
diff --git a/src/textfield/textfield.android.ts b/src/textfield/textfield.android.ts
diff --git a/src/textview/textview.android.ts b/src/textview/textview.android.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"dependencies": {`
`3`		`- "@nativescript/core": "rc",`
	`3`	`+ "@nativescript/core": "8.0.0-alpha.2",`
`4`	`4`	`"@nativescript-community/ui-material-activityindicator": "file:../packages/activityindicator",`
`5`	`5`	`"@nativescript-community/ui-material-bottomsheet": "file:../packages/bottomsheet",`
`6`	`6`	`"@nativescript-community/ui-material-bottomnavigationbar": "file:../packages/bottomnavigationbar",`
Original file line number	Diff line number	Diff line change
`@@ -12,9 +12,10 @@ import {`
`12`	`12`	`androidElevationProperty,`
`13`	`13`	`backgroundInternalProperty,`
`14`	`14`	`colorProperty,`
`15`		`- profile`
	`15`	`+ profile,`
	`16`	`+ Enums`
`16`	`17`	`} from '@nativescript/core';`
`17`		`-import { TextAlignment, TextTransform, textAlignmentProperty, textTransformProperty } from '@nativescript/core/ui/text-base';`
	`18`	`+import { textAlignmentProperty, textTransformProperty } from '@nativescript/core/ui/text-base';`
`18`	`19`	`import { ButtonBase, imageSourceProperty, srcProperty } from './button-common';`
`19`	`20`
`20`	`21`	`let LayoutInflater: typeof android.view.LayoutInflater;`
`@@ -140,7 +141,7 @@ export class Button extends ButtonBase {`
`140`	`141`	`setStrokeWidth(value) {`
`141`	`142`	`this.nativeViewProtected.setStrokeWidth(value);`
`142`	`143`	`}`
`143`		`- [textTransformProperty.setNative](value: TextTransform) {`
	`144`	`+ [textTransformProperty.setNative](value: Enums.TextTransformType) {`
`144`	`145`	`this.nativeViewProtected.setAllCaps(value !== 'none');`
`145`	`146`	`}`
`146`	`147`	`[backgroundInternalProperty.getDefault]() {`
`@@ -168,7 +169,7 @@ export class Button extends ButtonBase {`
`168`	`169`	`}`
`169`	`170`	`}`
`170`	`171`
`171`		`- [textAlignmentProperty.setNative](value: TextAlignment) {`
	`172`	`+ [textAlignmentProperty.setNative](value: Enums.TextAlignmentType) {`
`172`	`173`	`this.nativeTextViewProtected.setGravity(getHorizontalGravity(value) \| getVerticalGravity(this.verticalTextAlignment));`
`173`	`174`	`}`
`174`	`175`	`[verticalTextAlignmentProperty.setNative](value: VerticalTextAlignment) {`
Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,9 @@ import {`
`13`	`13`	`borderTopRightRadiusProperty,`
`14`	`14`	`colorProperty,`
`15`	`15`	`fontInternalProperty,`
	`16`	`+ Enums,`
`16`	`17`	`} from '@nativescript/core';`
`17`		`-import { TextTransform, textTransformProperty } from '@nativescript/core/ui/text-base';`
	`18`	`+import { textTransformProperty } from '@nativescript/core/ui/text-base';`
`18`	`19`	`import { ButtonBase, imageSourceProperty, srcProperty } from './button-common';`
`19`	`20`
`20`	`21`	`let buttonScheme: MDCContainerScheme;`
`@@ -220,7 +221,7 @@ export class Button extends ButtonBase {`
`220`	`221`	`}`
`221`	`222`	`}`
`222`	`223`
`223`		`- [textTransformProperty.setNative](value: TextTransform) {`
	`224`	`+ [textTransformProperty.setNative](value: Enums.TextTransformType) {`
`224`	`225`	`this.nativeViewProtected.uppercaseTitle = value !== 'none';`
`225`	`226`	`}`
`226`	`227`	`[rippleColorProperty.setNative](color: Color) {`