refactor

Author: vallemar

src/analytics/guaService.ts

@@ -43,9 +43,9 @@ export class GUAService {
     }
 
     private sendEvent(params): Promise<any> {
-        return new Promise<any>((res, rej) => {
+        return new Promise<void>((res, rej) => {
             this._visitor.event(params, (err) => {
-                return err ? rej(err) : res(params);
+                return err ? rej(err) : res();
             });
         });
     }

src/debug-adapter/nativeScriptDebugAdapter.ts

@@ -77,15 +77,15 @@ export class NativeScriptDebugAdapter extends ChromeDebugAdapter {
         let timeoutId;
 
         if (!this.isDisconnecting && this.isLiveSync) {
-            const portProm = new Promise<any>((res, rej) => {
+            const portProm = new Promise<void>((res, rej) => {
                 this.portWaitingResolve = res;
 
                 timeoutId = setTimeout(() => {
-                    res(null);
+                    res();
                 }, reconnectAfterLiveSyncTimeout);
             });
 
-            restartRequestArgs = await portProm;
+            restartRequestArgs = await portProm as any;
             this.isLiveSyncRestart = restartRequestArgs && !!restartRequestArgs.port;
             clearTimeout(timeoutId);
         }
@@ -148,7 +148,7 @@ export class NativeScriptDebugAdapter extends ChromeDebugAdapter {
         (ChromeDebugAdapter as any).SET_BREAKPOINTS_TIMEOUT = 20000;
 
         this.isLiveSync = args.watch;
-        transformedArgs.address = this.convertIosLoopbackAddress(transformedArgs.address, args.platform.toLowerCase());
+        transformedArgs.address = this.applyLoopbackAddress(transformedArgs.address, args.platform.toLowerCase());
 
         return super.attach(transformedArgs);
     }
@@ -269,7 +269,7 @@ export class NativeScriptDebugAdapter extends ChromeDebugAdapter {
         });
     }
 
-    private convertIosLoopbackAddress(address: string, platform: string) {
+    private applyLoopbackAddress(address: string, platform: string) {
         if (address === undefined && platform === "ios") {
             // If it is undefined it will use 127.0.0.1 and will fail on iOS
             return "localhost";

src/services/iOSTeamService.ts

@@ -4,7 +4,7 @@ import * as vscode from 'vscode';
 
 // tslint:disable-next-line:class-name
 export class iOSTeamService {
-    public selectTeam(): Promise<{ id: string, name: string }> {
+    public selectTeam(): Promise<{ id: string, name: string } | void> {
         return new Promise((resolve, reject) => {
             const workspaceTeamId = vscode.workspace.getConfiguration().get<string>('nativescript.iosTeamId');
 
@@ -39,7 +39,7 @@ export class iOSTeamService {
                         });
                     });
             } else {
-                resolve(null);
+                resolve();
             }
         });
     }