Skip to content

Commit 36be6dd

Browse files
committed
Better name for the grouping collector
1 parent 7e6d571 commit 36be6dd

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/CriteriaCollectorV2.kt renamed to src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/GroupingCriteriaCollector.kt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@ import org.mybatis.dynamic.sql.SqlBuilder
2525
import org.mybatis.dynamic.sql.SqlCriterion
2626
import org.mybatis.dynamic.sql.VisitableCondition
2727

28-
typealias CriteriaReceiverV2 = CriteriaCollectorV2.() -> Unit
28+
typealias GroupingCriteriaReceiver = GroupingCriteriaCollector.() -> Unit
2929

3030
@MyBatisDslMarker
31-
class CriteriaCollectorV2 {
31+
class GroupingCriteriaCollector {
3232
internal var initialCriterion: SqlCriterion? = null
3333
internal val subCriteria = mutableListOf<AndOrCriteriaGroup>()
3434

35-
fun and(criteriaReceiver: CriteriaReceiverV2) {
36-
val cc = CriteriaCollectorV2().apply(criteriaReceiver)
35+
fun and(criteriaReceiver: GroupingCriteriaReceiver) {
36+
val cc = GroupingCriteriaCollector().apply(criteriaReceiver)
3737
subCriteria.add(
3838
AndOrCriteriaGroup.Builder().withConnector("and")
3939
.withInitialCriterion(cc.initialCriterion)
@@ -42,8 +42,8 @@ class CriteriaCollectorV2 {
4242
)
4343
}
4444

45-
fun or(criteriaReceiver: CriteriaReceiverV2) {
46-
val cc = CriteriaCollectorV2().apply(criteriaReceiver)
45+
fun or(criteriaReceiver: GroupingCriteriaReceiver) {
46+
val cc = GroupingCriteriaCollector().apply(criteriaReceiver)
4747
subCriteria.add(
4848
AndOrCriteriaGroup.Builder().withConnector("or")
4949
.withInitialCriterion(cc.initialCriterion)
@@ -55,8 +55,8 @@ class CriteriaCollectorV2 {
5555
/**
5656
* This should only be specified once per scope, and should be first
5757
*/
58-
fun not(criteriaReceiver: CriteriaReceiverV2) {
59-
val cc = CriteriaCollectorV2().apply(criteriaReceiver)
58+
fun not(criteriaReceiver: GroupingCriteriaReceiver) {
59+
val cc = GroupingCriteriaCollector().apply(criteriaReceiver)
6060
initialCriterion = NotCriterion.Builder()
6161
.withInitialCriterion(cc.initialCriterion)
6262
.withSubCriteria(cc.subCriteria)
@@ -78,8 +78,8 @@ class CriteriaCollectorV2 {
7878
*
7979
* This should only be specified once per scope, and should be first
8080
*/
81-
fun group(criteriaReceiver: CriteriaReceiverV2) {
82-
val cc = CriteriaCollectorV2().apply(criteriaReceiver)
81+
fun group(criteriaReceiver: GroupingCriteriaReceiver) {
82+
val cc = GroupingCriteriaCollector().apply(criteriaReceiver)
8383
initialCriterion = CriteriaGroup.Builder()
8484
.withInitialCriterion(cc.initialCriterion)
8585
.withSubCriteria(cc.subCriteria)

src/main/kotlin/org/mybatis/dynamic/sql/util/kotlin/KotlinBaseBuilders.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,20 @@ fun WhereApplier.andThen(after: WhereApplier): WhereApplier = {
3838
@MyBatisDslMarker
3939
@Suppress("TooManyFunctions")
4040
abstract class KotlinBaseBuilder<D : AbstractWhereSupport<*>, B : KotlinBaseBuilder<D, B>> {
41-
fun where(criteria: CriteriaReceiverV2) {
42-
val criteriaCollector = CriteriaCollectorV2().apply(criteria)
41+
fun where(criteria: GroupingCriteriaReceiver) {
42+
val criteriaCollector = GroupingCriteriaCollector().apply(criteria)
4343

4444
getDsl().where(criteriaCollector.initialCriterion, criteriaCollector.subCriteria)
4545
}
4646

47-
fun and(criteria: CriteriaReceiverV2) {
48-
val criteriaCollector = CriteriaCollectorV2().apply(criteria)
47+
fun and(criteria: GroupingCriteriaReceiver) {
48+
val criteriaCollector = GroupingCriteriaCollector().apply(criteria)
4949

5050
getDsl().where().and(criteriaCollector.initialCriterion, criteriaCollector.subCriteria)
5151
}
5252

53-
fun or(criteria: CriteriaReceiverV2) {
54-
val criteriaCollector = CriteriaCollectorV2().apply(criteria)
53+
fun or(criteria: GroupingCriteriaReceiver) {
54+
val criteriaCollector = GroupingCriteriaCollector().apply(criteria)
5555

5656
getDsl().where().or(criteriaCollector.initialCriterion, criteriaCollector.subCriteria)
5757
}

0 commit comments

Comments
 (0)