crashes with mpv

[Laszlo-Fiat]

Thank you for your work.

I've compiled it on armtix linux on an Orange PI 3B (RK3566).
$ vainfo
Trying display: wayland
vainfo: VA-API version: 1.22 (libva 2.22.0)
vainfo: Driver version: v4l2
vainfo: Supported profile and entrypoints
VAProfileMPEG2Simple : VAEntrypointVLD
VAProfileMPEG2Main : VAEntrypointVLD
VAProfileH264Main : VAEntrypointVLD
VAProfileH264High : VAEntrypointVLD
VAProfileH264ConstrainedBaseline: VAEntrypointVLD
VAProfileVP8Version0_3 : VAEntrypointVLD
VAProfileH264MultiviewHigh : VAEntrypointVLD
VAProfileH264StereoHigh : VAEntrypointVLD

That is OK.

When I try to play anything in mpv using hardware acceleration, I get:
$ mpv -vo gpu --hwdec=auto-safe -v t.mkv

[..]
[vd] Opening decoder h264
[vd] Looking at hwdec h264-vaapi...
[vo/gpu] Loading hwdec drivers for format: 'vaapi'
[vo/gpu] Loading hwdec driver 'vaapi'
[vo/gpu/vaapi] Using EGL dmabuf interop via GL_EXT_EGL_image_storage
[vo/gpu/vaapi] Trying to open a x11 VA display...
[vo/gpu/vaapi] Trying to open a wayland VA display...
[vo/gpu/vaapi/vaapi] libva: VA-API version 1.22.0
[vo/gpu/vaapi/vaapi] libva: User environment variable requested driver 'v4l2'
[vo/gpu/vaapi/vaapi] libva: Trying to open /usr/lib/dri/v4l2_drv_video.so
[vo/gpu/vaapi/vaapi] libva: Found init function __vaDriverInit_1_22
[vo/gpu/vaapi/vaapi] libva: va_openDriver() returns 0
[vo/gpu/vaapi/vaapi] Initialized VAAPI: version 1.22
[vo/gpu/vaapi] Going to probe surface formats (may log bogus errors)...
/usr/include/c++/14.2.1/optional:482: constexpr const _Tp& std::_Optional_base_impl<_Tp, _Dp>::_M_get() const [with _Tp = std::reference_wrapper; _Dp = std::_Optional_base<std::reference_wrapper, true, true>]: Assertion 'this->_M_is_engaged()' failed.
Aborted

Is this crash in mpv or libva-v4l2?

[mxsrc]

Thanks for the report and the interest in the project. This definitely is an issue in libva-v4l2. In fact, the root cause seems to be the same as for #1. I'm working on a fix for the problem that should be available soon.