Move error handling to App.xaml.cs

Author: mx7b7

src/CodeSnip/App.xaml.cs

@@ -11,12 +11,22 @@ protected override async void OnStartup(StartupEventArgs e)
             var splashScreen = new Views.SplashScreenView.SplashScreen();
             splashScreen.Show();
 
-            var mainWindow = new MainWindow();
-            await PerformInitializationAsync(mainWindow);
-            MainWindow = mainWindow;
-            mainWindow.Show();
-
-            splashScreen.Close();
+            try
+            {
+                var mainWindow = new MainWindow();
+                await PerformInitializationAsync(mainWindow);
+                MainWindow = mainWindow;
+                mainWindow.Show();
+            }
+            catch (Exception ex)
+            {
+                MessageBox.Show($"A critical error occurred during application startup and the application will now close.\n\nError: {ex.Message}", "Startup Error", MessageBoxButton.OK, MessageBoxImage.Error);
+                Shutdown();
+            }
+            finally
+            {
+                splashScreen.Close();
+            }
         }
         private async Task PerformInitializationAsync(MainWindow mainWindow)
         {

src/CodeSnip/MainViewModel.cs

@@ -110,43 +110,32 @@ public enum SnippetFilterMode
         public MainViewModel(IFlyoutService flyoutService)
         {
             _flyoutService = flyoutService;
-            try
-            {
-                _menuOpenIcon = Application.Current.Resources["MenuOpen"] as Geometry;
-                _menuCloseIcon = Application.Current.Resources["MenuClose"] as Geometry;
-                if (_menuOpenIcon == null || _menuCloseIcon == null)
-                {
-                    throw new InvalidOperationException("Icons not found in resources.");
-                }
-
-                SplitViewOpenPaneLength = settingsService.PanelLength;
-                WindowX = settingsService.WindowX;
-                WindowY = settingsService.WindowY;
-                WindowWidth = settingsService.WindowWidth;
-                WindowHeight = settingsService.WindowHeight;
-                opt.EnableEmailHyperlinks = settingsService.EnableEmailLinks;
-                opt.EnableHyperlinks = settingsService.EnableHyperinks;
-                opt.ConvertTabsToSpaces = settingsService.TabToSpaces;
-                opt.HighlightCurrentLine = settingsService.HighlightLine;
-                opt.IndentationSize = settingsService.IntendationSize;
-
-                IsFilteringEnabled = settingsService.EnableFiltering;
-                EnableBraceStyleFolding = settingsService.EnableBraceStyleFolding;
-                EnablePythonFolding = settingsService.EnablePythonFolding;
-                EnableXmlFolding = settingsService.EnableXmlFolding;
-                ShowEmptyLanguages = settingsService.ShowEmptyLanguages;
-                ShowEmptyCategories = settingsService.ShowEmptyCategories;
 
-            }
-            catch (InvalidOperationException ex)
-            {
-                MessageBox.Show($"Error while starting the application:\n{ex.Message}");
-            }
-            catch (Exception ex)
+            _menuOpenIcon = Application.Current.Resources["MenuOpen"] as Geometry;
+            _menuCloseIcon = Application.Current.Resources["MenuClose"] as Geometry;
+            if (_menuOpenIcon == null || _menuCloseIcon == null)
             {
-                MessageBox.Show($"Unexpected error:\n{ex.Message}");
+                throw new InvalidOperationException("Icons not found in resources.");
             }
 
+            SplitViewOpenPaneLength = settingsService.PanelLength;
+            WindowX = settingsService.WindowX;
+            WindowY = settingsService.WindowY;
+            WindowWidth = settingsService.WindowWidth;
+            WindowHeight = settingsService.WindowHeight;
+            opt.EnableEmailHyperlinks = settingsService.EnableEmailLinks;
+            opt.EnableHyperlinks = settingsService.EnableHyperinks;
+            opt.ConvertTabsToSpaces = settingsService.TabToSpaces;
+            opt.HighlightCurrentLine = settingsService.HighlightLine;
+            opt.IndentationSize = settingsService.IntendationSize;
+
+            IsFilteringEnabled = settingsService.EnableFiltering;
+            EnableBraceStyleFolding = settingsService.EnableBraceStyleFolding;
+            EnablePythonFolding = settingsService.EnablePythonFolding;
+            EnableXmlFolding = settingsService.EnableXmlFolding;
+            ShowEmptyLanguages = settingsService.ShowEmptyLanguages;
+            ShowEmptyCategories = settingsService.ShowEmptyCategories;
+
         }
         public async Task InitializeAsync()
         {