fixed keybuilder nullreference issue raised by many. fixed appfabric utcdate issue raised by swayambhuba. fixed keygenerator querystring issue raised by ysrb.

Author: devtrends

.gitignore

@@ -0,0 +1,10 @@
+#OS junk files
+[Tt]humbs.db
+
+#Visual Studio files
+bin/
+obj/
+packages/
+*.user
+*.suo
+*.Publish.xml

DevTrends.MvcDonutCaching/DonutOutputCacheAttribute.cs

@@ -91,7 +91,7 @@ public override void OnActionExecuting(ActionExecutingContext filterContext)
 
                         if (_cacheSettings.IsServerCachingEnabled && filterContext.HttpContext.Response.StatusCode == 200)
                         {
-                            _outputCacheManager.AddItem(cacheKey, cacheItem, DateTime.Now.AddSeconds(_cacheSettings.Duration));
+                            _outputCacheManager.AddItem(cacheKey, cacheItem, DateTime.UtcNow.AddSeconds(_cacheSettings.Duration));
                         }
                     }
                 });

DevTrends.MvcDonutCaching/KeyBuilder.cs

@@ -45,7 +45,9 @@ public string BuildKey(string controllerName, string actionName, RouteValueDicti
 
         public string BuildKeyFragment(KeyValuePair<string, object> routeValue)
         {
-            return string.Format("{0}={1}#", routeValue.Key.ToLowerInvariant(), routeValue.Value.ToString().ToLowerInvariant());
+            var value = routeValue.Value == null ? "<null>" : routeValue.Value.ToString().ToLowerInvariant();
+
+            return string.Format("{0}={1}#", routeValue.Key.ToLowerInvariant(), value);
         }
     }
 }

DevTrends.MvcDonutCaching/KeyGenerator.cs

@@ -47,7 +47,8 @@ public string GenerateKey(ControllerContext context, CacheSettings cacheSettings
 
                 foreach (var queryStringKey in context.HttpContext.Request.QueryString.AllKeys)
                 {
-                    if (!routeValues.ContainsKey(queryStringKey.ToLowerInvariant()))
+                    // queryStringKey is null if url has qs name without value. e.g. test.com?q
+                    if (queryStringKey != null && !routeValues.ContainsKey(queryStringKey.ToLowerInvariant()))
                     {
                         routeValues.Add(queryStringKey.ToLowerInvariant(),
                                         context.HttpContext.Request.QueryString[queryStringKey].ToLowerInvariant());

DevTrends.MvcDonutCaching/Properties/AssemblyInfo.cs

@@ -11,5 +11,5 @@
 [assembly: AssemblyCulture("")]
 [assembly: ComVisible(false)]
 [assembly: Guid("ebcc3291-f04a-4511-b7eb-ddf57a74ada9")]
-[assembly: AssemblyVersion("1.2.0")]
-[assembly: AssemblyFileVersion("1.2.0")]
+[assembly: AssemblyVersion("1.2.1")]
+[assembly: AssemblyFileVersion("1.2.1")]

nuget/MvcDonutCaching.nuspec

@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
   <metadata>
     <id>MvcDonutCaching</id>
-    <version>1.2.0</version>
+    <version>1.2.1</version>
     <authors>Paul Hiles</authors>
     <owners>DevTrends</owners>
     <licenseUrl>http://mvcdonutcaching.codeplex.com/license</licenseUrl>