RUST-1357 Bump clippy version to 1.61.0 (#681)

Author: isabelatkinson

.evergreen/check-clippy.sh

@@ -3,11 +3,13 @@
 set -o errexit
 
 source ./.evergreen/configure-rust.sh
-# Pin clippy to the lastest version. This should be updated when new versions of Rust are released.
-rustup default 1.59.0
-
 source ./.evergreen/feature-combinations.sh
 
+# Pin clippy to the latest version. This should be updated when new versions of Rust are released.
+CLIPPY_VERSION=1.61.0
+
+rustup install $CLIPPY_VERSION
+
 for ((i = 0; i < ${#FEATURE_COMBINATIONS[@]}; i++)); do
-    cargo clippy --all-targets ${FEATURE_COMBINATIONS[$i]}  -p mongodb -- -D warnings
+    cargo +$CLIPPY_VERSION clippy --all-targets ${FEATURE_COMBINATIONS[$i]}  -p mongodb -- -D warnings
 done

src/client/session/mod.rs

@@ -382,7 +382,7 @@ impl ClientSession {
                         if let Some(defaults) = self.default_transaction_options() {
                             merge_options!(
                                 defaults,
-                                &mut options,
+                                options,
                                 [
                                     read_concern,
                                     write_concern,

src/cmap/conn/wire/header.rs

@@ -41,10 +41,12 @@ impl Header {
 
     /// Serializes the Header and writes the bytes to `w`.
     pub(crate) async fn write_to<W: AsyncWrite + Unpin>(&self, stream: &mut W) -> Result<()> {
-        stream.write(&self.length.to_le_bytes()).await?;
-        stream.write(&self.request_id.to_le_bytes()).await?;
-        stream.write(&self.response_to.to_le_bytes()).await?;
-        stream.write(&(self.op_code as i32).to_le_bytes()).await?;
+        stream.write_all(&self.length.to_le_bytes()).await?;
+        stream.write_all(&self.request_id.to_le_bytes()).await?;
+        stream.write_all(&self.response_to.to_le_bytes()).await?;
+        stream
+            .write_all(&(self.op_code as i32).to_le_bytes())
+            .await?;
 
         Ok(())
     }

src/test/util/mod.rs

@@ -402,7 +402,7 @@ impl TestClient {
             None => default_options,
         };
         if Self::new().await.is_sharded() && !use_multiple_mongoses {
-            options.hosts = options.hosts.iter().cloned().take(1).collect();
+            options.hosts = options.hosts.iter().take(1).cloned().collect();
         }
         options
     }