PYTHON-2868 Test Serverless behind a load balancer (#742)

(cherry picked from commit 968ee7b)

Author: ShaneHarvey

.evergreen/config.yml

@@ -426,9 +426,11 @@ functions:
           fi
           if [ -n "${test_serverless}" ]; then
             export TEST_SERVERLESS=1
-            export MONGODB_URI="${MONGODB_URI}"
+            export MONGODB_URI="${SINGLE_ATLASPROXY_SERVERLESS_URI}"
             export SERVERLESS_ATLAS_USER="${SERVERLESS_ATLAS_USER}"
             export SERVERLESS_ATLAS_PASSWORD="${SERVERLESS_ATLAS_PASSWORD}"
+            export SINGLE_MONGOS_LB_URI="${SINGLE_ATLASPROXY_SERVERLESS_URI}"
+            export MULTI_MONGOS_LB_URI="${MULTI_ATLASPROXY_SERVERLESS_URI}"
           fi
 
           PYTHON_BINARY=${PYTHON_BINARY} \
@@ -883,10 +885,11 @@ task_groups:
           script: |
             ${PREPARE_SHELL}
             set +o xtrace
-            SERVERLESS_DRIVERS_GROUP=${SERVERLESS_DRIVERS_GROUP} \
-            SERVERLESS_API_PUBLIC_KEY=${SERVERLESS_API_PUBLIC_KEY} \
-            SERVERLESS_API_PRIVATE_KEY=${SERVERLESS_API_PRIVATE_KEY} \
-            PROJECT="mongo-python-driver-312" \
+            LOADBALANCED=ON \
+              SERVERLESS_DRIVERS_GROUP=${SERVERLESS_DRIVERS_GROUP} \
+              SERVERLESS_API_PUBLIC_KEY=${SERVERLESS_API_PUBLIC_KEY} \
+              SERVERLESS_API_PRIVATE_KEY=${SERVERLESS_API_PRIVATE_KEY} \
+              PROJECT="mongo-python-driver-312" \
               bash ${DRIVERS_TOOLS}/.evergreen/serverless/create-instance.sh
       - command: expansions.update
         params:
@@ -898,9 +901,9 @@ task_groups:
             ${PREPARE_SHELL}
             set +o xtrace
             SERVERLESS_DRIVERS_GROUP=${SERVERLESS_DRIVERS_GROUP} \
-            SERVERLESS_API_PUBLIC_KEY=${SERVERLESS_API_PUBLIC_KEY} \
-            SERVERLESS_API_PRIVATE_KEY=${SERVERLESS_API_PRIVATE_KEY} \
-            SERVERLESS_INSTANCE_NAME=${SERVERLESS_INSTANCE_NAME} \
+              SERVERLESS_API_PUBLIC_KEY=${SERVERLESS_API_PUBLIC_KEY} \
+              SERVERLESS_API_PRIVATE_KEY=${SERVERLESS_API_PRIVATE_KEY} \
+              SERVERLESS_INSTANCE_NAME=${SERVERLESS_INSTANCE_NAME} \
               bash ${DRIVERS_TOOLS}/.evergreen/serverless/delete-instance.sh
     tasks:
       - ".serverless"

test/__init__.py

@@ -107,12 +107,14 @@
     db_user = res['username'] or db_user
     db_pwd = res['password'] or db_pwd
 elif TEST_SERVERLESS:
-    res = parse_uri(os.environ["MONGODB_URI"])
-    host, port = res['nodelist'].pop(0)
-    additional_serverless_mongoses = res['nodelist']
+    TEST_LOADBALANCER = True
+    res = parse_uri(SINGLE_MONGOS_LB_URI)
+    host, port = res['nodelist'][0]
     db_user = res['username'] or db_user
     db_pwd = res['password'] or db_pwd
     TLS_OPTIONS = {'tls': True}
+    # Spec says serverless tests must be run with compression.
+    COMPRESSORS = COMPRESSORS or 'zlib'
 
 
 def is_server_resolvable():
@@ -226,7 +228,7 @@ def __init__(self):
         self.version = Version(-1)  # Needs to be comparable with Version
         self.auth_enabled = False
         self.test_commands_enabled = False
-        self.server_parameters = None
+        self.server_parameters = {}
         self.is_mongos = False
         self.mongoses = []
         self.is_rs = False
@@ -241,7 +243,7 @@ def __init__(self):
         self.is_data_lake = False
         self.load_balancer = TEST_LOADBALANCER
         self.serverless = TEST_SERVERLESS
-        if self.load_balancer:
+        if self.load_balancer or self.serverless:
             self.default_client_options["loadBalanced"] = True
         if COMPRESSORS:
             self.default_client_options["compressors"] = COMPRESSORS
@@ -381,7 +383,11 @@ def _init_client(self):
             self.w = len(hello.get("hosts", [])) or 1
             self.version = Version.from_client(self.client)
 
-            if TEST_SERVERLESS:
+            if self.serverless:
+                self.server_parameters = {
+                    'requireApiVersion': False,
+                    'enableTestCommands': True,
+                }
                 self.test_commands_enabled = True
                 self.has_ipv6 = False
             else:
@@ -401,14 +407,11 @@ def _init_client(self):
 
             self.is_mongos = (self.hello.get('msg') == 'isdbgrid')
             if self.is_mongos:
-                if self.serverless:
-                    self.mongoses.append(self.client.address)
-                    self.mongoses.extend(additional_serverless_mongoses)
-                else:
+                address = self.client.address
+                self.mongoses.append(address)
+                if not self.serverless:
                     # Check for another mongos on the next port.
-                    address = self.client.address
                     next_address = address[0], address[1] + 1
-                    self.mongoses.append(address)
                     mongos_client = self._connect(
                         *next_address, **self.default_client_options)
                     if mongos_client:

test/load_balancer/cursors.json

@@ -902,6 +902,11 @@
     },
     {
       "description": "listCollections pins the cursor to a connection",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "listCollections",
@@ -1151,6 +1156,11 @@
     },
     {
       "description": "change streams pin to a connection",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "createChangeStream",

test/load_balancer/sdam-error-handling.json

@@ -127,6 +127,11 @@
   "tests": [
     {
       "description": "only connections for a specific serviceId are closed when pools are cleared",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "createFindCursor",
@@ -255,7 +260,7 @@
       ]
     },
     {
-      "description": "errors during the initial connection hello are ignore",
+      "description": "errors during the initial connection hello are ignored",
       "runOnRequirements": [
         {
           "minServerVersion": "4.9"
@@ -274,7 +279,9 @@
               },
               "data": {
                 "failCommands": [
-                  "isMaster"
+                  "ismaster",
+                  "isMaster",
+                  "hello"
                 ],
                 "closeConnection": true,
                 "appName": "lbSDAMErrorTestClient"

test/load_balancer/transactions.json

@@ -607,6 +607,11 @@
     },
     {
       "description": "pinned connection is released after a transient non-network CRUD error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -715,6 +720,11 @@
     },
     {
       "description": "pinned connection is released after a transient network CRUD error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",
@@ -831,6 +841,11 @@
     },
     {
       "description": "pinned connection is released after a transient non-network commit error",
+      "runOnRequirements": [
+        {
+          "serverless": "forbid"
+        }
+      ],
       "operations": [
         {
           "name": "failPoint",

test/load_balancer/wait-queue-timeouts.json

@@ -15,7 +15,7 @@
         "useMultipleMongoses": true,
         "uriOptions": {
           "maxPoolSize": 1,
-          "waitQueueTimeoutMS": 5
+          "waitQueueTimeoutMS": 50
         },
         "observeEvents": [
           "connectionCheckedOutEvent",

test/test_client.py

@@ -906,7 +906,7 @@ def test_auth_from_uri(self):
             "pymongo_test", "user", "pass", roles=['userAdmin', 'readWrite'])
 
         with self.assertRaises(OperationFailure):
-            connected(rs_or_single_client(
+            connected(rs_or_single_client_noauth(
                 "mongodb://a:b@%s:%d" % (host, port)))
 
         # No error.
@@ -916,7 +916,7 @@ def test_auth_from_uri(self):
         # Wrong database.
         uri = "mongodb://admin:pass@%s:%d/pymongo_test" % (host, port)
         with self.assertRaises(OperationFailure):
-            connected(rs_or_single_client(uri))
+            connected(rs_or_single_client_noauth(uri))
 
         # No error.
         connected(rs_or_single_client_noauth(
@@ -940,7 +940,7 @@ def test_username_and_password(self):
         client_context.create_user("admin", "ad min", "pa/ss")
         self.addCleanup(client_context.drop_user, "admin", "ad min")
 
-        c = rs_or_single_client(username="ad min", password="pa/ss")
+        c = rs_or_single_client_noauth(username="ad min", password="pa/ss")
 
         # Username and password aren't in strings that will likely be logged.
         self.assertNotIn("ad min", repr(c))
@@ -952,7 +952,8 @@ def test_username_and_password(self):
         c.server_info()
 
         with self.assertRaises(OperationFailure):
-            rs_or_single_client(username="ad min", password="foo").server_info()
+            rs_or_single_client_noauth(
+                username="ad min", password="foo").server_info()
 
     @client_context.require_auth
     @ignore_deprecations
@@ -1005,11 +1006,7 @@ def test_unix_socket(self):
         if not os.access(mongodb_socket, os.R_OK):
             raise SkipTest("Socket file is not accessible")
 
-        if client_context.auth_enabled:
-            uri = "mongodb://%s:%s@%s" % (db_user, db_pwd, encoded_socket)
-        else:
-            uri = "mongodb://%s" % encoded_socket
-
+        uri = "mongodb://%s" % encoded_socket
         # Confirm we can do operations via the socket.
         client = rs_or_single_client(uri)
         client.pymongo_test.test.insert_one({"dummy": "object"})

test/test_cmap.py

@@ -51,6 +51,7 @@
                         get_pools,
                         rs_or_single_client,
                         single_client,
+                        single_client_noauth,
                         TestCreator,
                         wait_until)
 from test.utils_spec_runner import SpecRunnerThread
@@ -274,7 +275,7 @@ def test_3_uri_connection_pool_options(self):
         opts = '&'.join(['%s=%s' % (k, v)
                          for k, v in self.POOL_OPTIONS.items()])
         uri = 'mongodb://%s/?%s' % (client_context.pair, opts)
-        client = rs_or_single_client(uri, **self.credentials)
+        client = rs_or_single_client(uri)
         self.addCleanup(client.close)
         pool_opts = get_pool(client).opts
         self.assertEqual(pool_opts.non_default_options, self.POOL_OPTIONS)
@@ -334,8 +335,9 @@ def mock_connect(*args, **kwargs):
 
     def test_5_check_out_fails_auth_error(self):
         listener = CMAPListener()
-        client = single_client(username="notauser", password="fail",
-                               event_listeners=[listener])
+        client = single_client_noauth(
+            username="notauser", password="fail",
+            event_listeners=[listener])
         self.addCleanup(client.close)
 
         # Attempt to create a new connection.

test/test_load_balancer.py

@@ -38,6 +38,7 @@
 
 class TestLB(IntegrationTest):
     RUN_ON_LOAD_BALANCER = True
+    RUN_ON_SERVERLESS = True
 
     def test_connections_are_only_returned_once(self):
         pool = get_pool(self.client)
@@ -97,7 +98,6 @@ def _test_no_gc_deadlock(self, create_resource):
               "failCommands": [
                 "find", "aggregate"
               ],
-              "errorCode": 91,
               "closeConnection": True,
             }
         }

test/test_unified_format.py

@@ -33,7 +33,8 @@
     class_name_prefix='UnifiedTestFormat',
     expected_failures=[
         'Client side error in command starting transaction',    # PYTHON-1894
-    ]))
+    ],
+    RUN_ON_SERVERLESS=False))
 
 
 globals().update(generate_test_classes(
@@ -43,7 +44,8 @@
     bypass_test_generation_errors=True,
     expected_failures=[
         '.*',       # All tests expected to fail
-    ]))
+    ],
+    RUN_ON_SERVERLESS=False))
 
 
 class TestMatchEvaluatorUtil(unittest.TestCase):