PHPC-879: Remove dependency on php_date_get_immutable_ce()

Author: jmikola

php_phongo.c

@@ -74,6 +74,7 @@ ZEND_DECLARE_MODULE_GLOBALS(mongodb)
 #endif
 
 /* Declare zend_class_entry dependencies, which are initialized in MINIT */
+zend_class_entry *php_phongo_date_immutable_ce;
 zend_class_entry *php_phongo_json_serializable_ce;
 
 php_phongo_server_description_type_map_t
@@ -1909,12 +1910,17 @@ PHP_MINIT_FUNCTION(mongodb)
 	*/
 
 	/* Initialize zend_class_entry dependencies.
+	 *
+	 * Although DateTimeImmutable was introduced in PHP 5.5.0,
+	 * php_date_get_immutable_ce() is not available in PHP versions before
+	 * 5.5.24 and 5.6.8.
 	 *
 	 * Although JsonSerializable was introduced in PHP 5.4.0,
 	 * php_json_serializable_ce is not exported in PHP versions before 5.4.26
 	 * and 5.5.10. For later PHP versions, looking up the class manually also
 	 * helps with distros that disable LTDL_LAZY for dlopen() (e.g. Fedora).
 	 */
+	php_phongo_date_immutable_ce = php_phongo_fetch_internal_class(ZEND_STRL("datetimeimmutable") TSRMLS_CC);
 	php_phongo_json_serializable_ce = php_phongo_fetch_internal_class(ZEND_STRL("jsonserializable") TSRMLS_CC);
 
 	if (php_phongo_json_serializable_ce == NULL) {

php_phongo_classes.h

@@ -20,6 +20,7 @@
 #include "php_phongo_structs.h"
 
 /* Export zend_class_entry dependencies, which are initialized in MINIT */
+extern zend_class_entry *php_phongo_date_immutable_ce;
 extern zend_class_entry *php_phongo_json_serializable_ce;
 
 #if PHP_VERSION_ID >= 70000

src/BSON/UTCDateTime.c

@@ -176,12 +176,9 @@ PHP_METHOD(UTCDateTime, __construct)
 	}
 
 	if (Z_TYPE_P(milliseconds) == IS_OBJECT) {
-		if (instanceof_function(Z_OBJCE_P(milliseconds), php_date_get_date_ce() TSRMLS_CC)) {
+		if (instanceof_function(Z_OBJCE_P(milliseconds), php_date_get_date_ce() TSRMLS_CC) ||
+		    (php_phongo_date_immutable_ce && instanceof_function(Z_OBJCE_P(milliseconds), php_phongo_date_immutable_ce TSRMLS_CC))) {
 			php_phongo_utcdatetime_init_from_date(intern, Z_PHPDATE_P(milliseconds));
-#if PHP_VERSION_ID >= 50500
-		} else if (instanceof_function(Z_OBJCE_P(milliseconds), php_date_get_immutable_ce() TSRMLS_CC)) {
-			php_phongo_utcdatetime_init_from_date(intern, Z_PHPDATE_P(milliseconds));
-#endif
 		} else {
 			phongo_throw_exception(PHONGO_ERROR_INVALID_ARGUMENT TSRMLS_CC, "Expected instance of DateTimeInterface, %s given", ZSTR_VAL(Z_OBJCE_P(milliseconds)->name));
 		}