-
Notifications
You must be signed in to change notification settings - Fork 84
feat: add a download script to facilitate easy use in CI MONGOSH-2687 #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
addaleax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we need to have some sort of triage conversation in the team here, we don't typically add this type of feature on a very ad-hoc basis but this does make sense to me to add in general
Co-authored-by: Anna Henningsen <github@addaleax.net>
Co-authored-by: Anna Henningsen <github@addaleax.net>
|
@addaleax Triage: by all means. I just wanted to PoC the idea to get the ball rolling. |
| esac | ||
|
|
||
| jq_query=$(cat <<EOF | ||
| .versions[0].downloads[] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't really do a semver comparison here, right? Otherwise I think that would be highly preferable.
If we leave this as-is, I'd leave a comment in
| currentVersions.sort((a, b) => semver.rcompare(a.version, b.version)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(@addaleax added the comment since jQ is a funky—if poetic, heh—place to do things like semver sorting.)
… add_download_script
No description provided.