fix: set directConnection true on direct connections COMPASS-4534 (#337)

Author: Anemy

lib/connect.js

@@ -215,6 +215,17 @@ const getTasks = (model, setupListeners) => {
 
       validOptions.useNewUrlParser = true;
       validOptions.useUnifiedTopology = true;
+      if (
+        model.directConnection === undefined &&
+        model.hosts.length === 1 &&
+        (model.replicaSet === undefined || model.replicaSet === '')
+      ) {
+        // Previous to the node driver 3.6.3, directConnection was
+        // set to true under these conditions. In 3.6.3 this defaulting
+        // behavior was removed and now we add it. COMPASS-4534
+        // https://github.com/mongodb/node-mongodb-native/commit/f8fd310a11a91db82f1c0ddc57482b8edabc231b
+        validOptions.directConnection = true;
+      }
 
       const mongoClient = new MongoClient(model.driverUrlWithSsh, validOptions);
 

lib/model.js

@@ -169,7 +169,8 @@ const CONNECTION_STRING_OPTIONS = {
       'pythonLegacy'
     ],
     default: undefined
-  }
+  },
+  directConnection: { type: 'boolean', default: undefined }
 };
 
 assign(props, CONNECTION_STRING_OPTIONS);

package-lock.json

@@ -25,7 +25,7 @@
     "async": "^3.1.0",
     "debug": "^4.1.1",
     "lodash": "^4.17.15",
-    "mongodb": "^3.6.1",
+    "mongodb": "^3.6.3",
     "raf": "^3.4.1",
     "ssh2": "^0.8.7",
     "storage-mixin": "^3.3.4"

package.json

@@ -37,6 +37,7 @@ describe('connection model connector', () => {
 
             assert.deepStrictEqual(options, {
               connectWithNoPrimary: true,
+              directConnection: true,
               readPreference: 'primary',
               useNewUrlParser: true,
               useUnifiedTopology: true

test/connect.test.js

@@ -548,6 +548,39 @@ describe('connection model partser should parse URI components such as', () => {
           }
         );
       });
+
+      it('defaults directConnection undefined', (done) => {
+        Connection.from(
+          'mongodb://localhost:27017',
+          (error, result) => {
+            expect(error).to.not.exist;
+            expect(result.directConnection).to.be.equal(undefined);
+            done();
+          }
+        );
+      });
+
+      it('saves directConnection true', (done) => {
+        Connection.from(
+          'mongodb://localhost:27017/?directConnection=true',
+          (error, result) => {
+            expect(error).to.not.exist;
+            expect(result.directConnection).to.be.equal(true);
+            done();
+          }
+        );
+      });
+
+      it('saves directConnection false', (done) => {
+        Connection.from(
+          'mongodb://localhost:27017/?directConnection=false',
+          (error, result) => {
+            expect(error).to.not.exist;
+            expect(result.directConnection).to.be.equal(false);
+            done();
+          }
+        );
+      });
     });
 
     describe('miscellaneous configuration', () => {