chore(typescript): enable erasableSyntaxOnly for the whole repo; add temporary ts-expect-errors to enums (#7613)

* chore(typescript): enable erasableSyntaxOnly for the whole repo; add temporary ts-expect-errors to enums

* chore: add ticket number to TODO

Author: gribnoysup

configs/testing-library-compass/src/index.tsx

@@ -127,8 +127,10 @@ export class MockDataService
       | 'instance'
     >
 {
-  constructor(private connectionOptions: ConnectionInfo['connectionOptions']) {
+  private connectionOptions: ConnectionInfo['connectionOptions'];
+  constructor(connectionOptions: ConnectionInfo['connectionOptions']) {
     super();
+    this.connectionOptions = connectionOptions;
     this.setMaxListeners(0);
   }
   getConnectionString() {

configs/tsconfig-compass/tsconfig.common.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "removeComments": false,
     "moduleResolution": "node16",
-    "module": "node16"
+    "module": "node16",
+    "erasableSyntaxOnly": true
   }
 }

configs/tsconfig-compass/tsconfig.react.json

@@ -3,6 +3,7 @@
   "compilerOptions": {
     "removeComments": false,
     "moduleResolution": "node16",
-    "module": "node16"
+    "module": "node16",
+    "erasableSyntaxOnly": true
   }
 }

packages/atlas-service/src/atlas-service.ts

@@ -53,13 +53,24 @@ function getAutomationAgentClusterId(
 }
 
 export class AtlasService {
+  private readonly authService: AtlasAuthService;
+  private readonly preferences: PreferencesAccess;
+  private readonly logger: Logger;
+  private readonly options?: AtlasServiceOptions;
+  private readonly defaultConfigOverride?: AtlasServiceConfig;
   constructor(
-    private readonly authService: AtlasAuthService,
-    private readonly preferences: PreferencesAccess,
-    private readonly logger: Logger,
-    private readonly options?: AtlasServiceOptions,
-    private readonly defaultConfigOverride?: AtlasServiceConfig
-  ) {}
+    authService: AtlasAuthService,
+    preferences: PreferencesAccess,
+    logger: Logger,
+    options?: AtlasServiceOptions,
+    defaultConfigOverride?: AtlasServiceConfig
+  ) {
+    this.authService = authService;
+    this.preferences = preferences;
+    this.logger = logger;
+    this.options = options;
+    this.defaultConfigOverride = defaultConfigOverride;
+  }
   // Config value is dynamic to make sure that process.env overrides are taken
   // into account in runtime
   get config(): AtlasServiceConfig {

packages/atlas-service/src/store/atlas-signin-reducer.ts

@@ -35,6 +35,7 @@ export type AtlasSignInThunkAction<
   A extends AnyAction = AnyAction
 > = ThunkAction<R, AtlasSignInState, { atlasAuthService: AtlasAuthService }, A>;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export const enum AtlasSignInActions {
   RestoringStart = 'atlas-service/atlas-signin/StartRestoring',
   RestoringFailed = 'atlas-service/atlas-signin/RestoringFailed',

packages/compass-aggregations/src/modules/aggregation.ts

@@ -41,6 +41,7 @@ export const WriteOperation = {
   Overwrite: 'overwriting',
 } as const;
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   RunAggregation = 'compass-aggeregations/runAggregation',
   AggregationStarted = 'compass-aggregations/aggregationStarted',

packages/compass-aggregations/src/modules/auto-preview.ts

@@ -7,6 +7,7 @@ import type { RestorePipelineAction } from './saved-pipeline';
 import { RESTORE_PIPELINE } from './saved-pipeline';
 import { isAction } from '../utils/is-action';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   AutoPreviewToggled = 'compass-aggregations/autoPreviewToggled',
 }

packages/compass-aggregations/src/modules/collection-stats.ts

@@ -20,6 +20,7 @@ export function pickCollectionStats(collection: Collection): CollectionStats {
   };
 }
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 enum CollectionStatsActions {
   CollectionStatsFetched = 'compass-aggregations/collection-stats/CollectionStatsFetched',
 }

packages/compass-aggregations/src/modules/collections-fields.ts

@@ -12,6 +12,7 @@ export type CollectionInfo = Pick<Collection, 'name' | 'type'>;
 
 type CollectionType = CollectionInfo['type'];
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   CollectionsFetch = 'compass-aggregations/collectionsFetched',
   CollectionFieldsFetched = 'compass-aggregations/collectionFieldsFetched',

packages/compass-aggregations/src/modules/count-documents.ts

@@ -10,6 +10,7 @@ import { ActionTypes as ConfirmNewPipelineActions } from './is-new-pipeline-conf
 import { getPipelineFromBuilderState } from './pipeline-builder/builder-helpers';
 import { isAction } from '../utils/is-action';
 
+// @ts-expect-error TODO(COMPASS-10124): replace enums with const kv objects
 export enum ActionTypes {
   CountStarted = 'compass-aggregations/countStarted',
   CountFinished = 'compass-aggregations/countFinished',