fix(writableStoreOverlay): append dont clear

brianmcgillion · brianmcgillion · commit 1acf2a86cb28 · 2025-12-07T09:02:44.000+04:00
lib.optional returns the empty set [] when a check is false.
In this case it causes the options to be set to an empty list which the module
does not allow. So append the new options if true, and append [] when false.

Signed-off-by: Brian McGillion &lt;bmg.avoin@gmail.com&gt;
diff --git a/nixos-modules/microvm/mounts.nix b/nixos-modules/microvm/mounts.nix
@@ -87,7 +87,7 @@ lib.mkIf config.microvm.guest.enable {
           upperdir = "${writableStoreOverlay}/store";
           workdir = "${writableStoreOverlay}/work";
         };
-        options = lib.optional isRwStoreVirtiofsShare "userxattr";
+        options = lib.mkAfter (lib.optional isRwStoreVirtiofsShare "userxattr");
       };
     }
   ) {

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ lib.mkIf config.microvm.guest.enable {`
`87`	`87`	`upperdir = "${writableStoreOverlay}/store";`
`88`	`88`	`workdir = "${writableStoreOverlay}/work";`
`89`	`89`	`};`
`90`		`- options = lib.optional isRwStoreVirtiofsShare "userxattr";`
	`90`	`+ options = lib.mkAfter (lib.optional isRwStoreVirtiofsShare "userxattr");`
`91`	`91`	`};`
`92`	`92`	`}`
`93`	`93`	`) {`