nes: model picker: support in JointCompletionsProvider (#2433)

* nes: model picker: fix: correct init and model picking order

    nes: fetched models should check if they're already known as well

    nes: fix: ensure to update undesired models before updating preferred model

    this's important because there's code that reacts to preferred model change and needs to know latest undesired models

    nes: minimize failure possibility

    nes: fix: make sure to init undesiredModelsManager earlier than observables use them

    nes: don't memorize if exp-configured model is picked

    nes: joint: support model picker

* nes: model picker: support in JointCompletionsProvider

* nes: enable model picker for the team

Author: ulugbekna

src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts

@@ -5,6 +5,7 @@
 
 import { join } from 'path';
 import * as vscode from 'vscode';
+import { InlineCompletionModelInfo } from 'vscode';
 import { IAuthenticationService, IExperimentationService } from '../../../lib/node/chatLibMain';
 import { ConfigKey, IConfigurationService } from '../../../platform/configuration/common/configurationService';
 import { IEnvService } from '../../../platform/env/common/envService';
@@ -244,6 +245,14 @@ class JointCompletionsProvider extends Disposable implements vscode.InlineComple
 
 	public onDidChange?: vscode.Event<void> | undefined;
 
+	//#region Model picker
+	public readonly onDidChangeModelInfo = this._inlineEditProvider?.onDidChangeModelInfo;
+	public readonly setCurrentModelId = this._inlineEditProvider?.setCurrentModelId?.bind(this._inlineEditProvider);
+	public get modelInfo(): InlineCompletionModelInfo | undefined {
+		return this._inlineEditProvider?.modelInfo;
+	}
+	//#endregion
+
 	constructor(
 		private readonly _completionsProvider: CopilotInlineCompletionItemProvider | undefined,
 		private readonly _inlineEditProvider: InlineCompletionProviderImpl | undefined,

src/platform/configuration/common/configurationService.ts

@@ -698,7 +698,7 @@ export namespace ConfigKey {
 		 */
 		export const DebugReportFeedback = defineTeamInternalSetting<boolean>('chat.advanced.debug.reportFeedback', ConfigType.Simple, { defaultValue: false, teamDefaultValue: true });
 		export const InlineEditsIgnoreCompletionsDisablement = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.ignoreCompletionsDisablement', ConfigType.Simple, false, vBoolean());
-		export const InlineEditsModelPickerEnabled = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.modelPicker.enabled', ConfigType.ExperimentBased, false, vBoolean());
+		export const InlineEditsModelPickerEnabled = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.modelPicker.enabled', ConfigType.ExperimentBased, { defaultValue: false, teamDefaultValue: true }, vBoolean());
 		export const InlineEditsUseSlashModels = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.useSlashModels', ConfigType.ExperimentBased, false);
 		export const InlineEditsLogContextRecorderEnabled = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.logContextRecorder.enabled', ConfigType.Simple, false);
 		export const InlineEditsHideInternalInterface = defineTeamInternalSetting<boolean>('chat.advanced.inlineEdits.hideInternalInterface', ConfigType.Simple, false, vBoolean());