Run local eslint rules directly as typescript (#2312)

* Run local eslint rules directly as typescript

Remove the need to use `tsx`

* Bump required node version

Matches the version we use in vscode repo

* Align node versions

* Always use `/`

* Try fixing windows

* Try another fix for windows

Author: mjbvz

.eslintplugin/index.js

@@ -0,0 +1,19 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+import type { LooseRuleDefinition } from '@typescript-eslint/utils/ts-eslint';
+import * as glob from 'glob';
+import path from 'path';
+
+// Re-export all .ts files as rules
+const rules: Record<string, LooseRuleDefinition> = {};
+await Promise.all(
+	glob.sync('*.ts', { cwd: import.meta.dirname })
+		.filter(file => !file.endsWith('index.ts') && !file.endsWith('utils.ts'))
+		.map(async file => {
+			rules[path.basename(file, '.ts')] = (await import('./' + file)).default;
+		})
+);
+
+export { rules };

.eslintplugin/index.ts

@@ -5,13 +5,13 @@
 
 import * as eslint from 'eslint';
 
-export = new class NoBadGDPRComment implements eslint.Rule.RuleModule {
+export default new class NoBadGDPRComment implements eslint.Rule.RuleModule {
 
 	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
 
 		return {
 			['Program'](node) {
-				for (const comment of (<eslint.AST.Program>node).comments) {
+				for (const comment of (node as eslint.AST.Program).comments) {
 					if (comment.type !== 'Block' || !comment.loc) {
 						continue;
 					}

.eslintplugin/no-bad-gdpr-comment.ts

@@ -7,7 +7,7 @@ import * as eslint from 'eslint';
 import { readdirSync } from 'fs';
 import path from 'path';
 
-export = new class NoTestOnly implements eslint.Rule.RuleModule {
+export default new class NoTestOnly implements eslint.Rule.RuleModule {
 
 	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
 

.eslintplugin/no-funny-filename.ts

@@ -6,7 +6,7 @@
 import { TSESTree } from '@typescript-eslint/typescript-estree';
 import * as eslint from 'eslint';
 
-export = new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
+export default new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",
@@ -56,7 +56,7 @@ export = new class NoGDPREventNameMismatch implements eslint.Rule.RuleModule {
 
 		return {
 			['ExpressionStatement MemberExpression Identifier[name=/^send.*TelemetryEvent$/]'](node: any) {
-				const esNode = <TSESTree.Identifier>node;
+				const esNode = node as TSESTree.Identifier;
 				const gdprCommentEventName = getEventNameFromLeadingGdprComment(esNode);
 				if (!gdprCommentEventName) {
 					return;

.eslintplugin/no-gdpr-event-name-mismatch.ts

@@ -5,7 +5,7 @@
 
 import * as eslint from 'eslint';
 
-export = new class NoInstanceofUri implements eslint.Rule.RuleModule {
+export default new class NoInstanceofUri implements eslint.Rule.RuleModule {
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",
 		fixable: "code",

.eslintplugin/no-instanceof-uri.ts

@@ -5,7 +5,7 @@
 
 import * as eslint from 'eslint';
 
-export = new class MissingTSXLinebreak implements eslint.Rule.RuleModule {
+export default new class MissingTSXLinebreak implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: "problem",

.eslintplugin/no-missing-linebreak.ts

@@ -5,7 +5,7 @@
 
 import * as eslint from 'eslint';
 
-export = new class NoBadGDPRComment implements eslint.Rule.RuleModule {
+export default new class NoBadGDPRComment implements eslint.Rule.RuleModule {
 	readonly meta: eslint.Rule.RuleMetaData = {
 		type: 'problem',
 		docs: {

.eslintplugin/no-restricted-copilot-pr-string.ts

@@ -7,9 +7,9 @@ import { TSESTree } from '@typescript-eslint/typescript-estree';
 import * as eslint from 'eslint';
 import { dirname, join, relative } from 'path';
 import picomatch from 'picomatch';
-import { createImportRuleListener } from './utils';
+import { createImportRuleListener } from './utils.ts';
 
-export = new class implements eslint.Rule.RuleModule {
+export default new class implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {
 		messages: {
@@ -30,13 +30,13 @@ export = new class implements eslint.Rule.RuleModule {
 	};
 
 	create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
-		let fileRelativePath = relative(dirname(__dirname), context.getFilename());
+		let fileRelativePath = relative(dirname(import.meta.dirname), context.getFilename());
 		fileRelativePath = fileRelativePath.replace(/\\/g, '/');
 
 		if (!fileRelativePath.endsWith('/')) {
 			fileRelativePath += '/';
 		}
-		const ruleArgs = <Record<string, string[]>>context.options[0];
+		const ruleArgs = context.options[0] as Record<string, string[]>;
 
 		const matchingKey = Object.keys(ruleArgs).find(key => fileRelativePath.startsWith(key) || picomatch(key)(fileRelativePath));
 		if (!matchingKey) {

.eslintplugin/no-runtime-import.ts

@@ -5,9 +5,9 @@
 
 import * as eslint from 'eslint';
 import { dirname, join } from 'path';
-import { createImportRuleListener } from './utils';
+import { createImportRuleListener } from './utils.ts';
 
-export = new class implements eslint.Rule.RuleModule {
+export default new class implements eslint.Rule.RuleModule {
 
 	readonly meta: eslint.Rule.RuleMetaData = {};