fixed the issue with defualt values for options not loaded correctly (#581)

Author: llali

src/Microsoft.SqlTools.ServiceLayer/Scripting/ScriptAsOptions.cs

@@ -691,7 +691,7 @@ public override bool? UniqueKeys
         /// <summary>
         /// Returns the value of ScriptIndexes Property
         /// </summary>
-        public bool? DriIndexes { get { return ScriptOptions.ScriptIndexes; } }
+        public bool? Indexes { get { return ScriptOptions.ScriptIndexes; } }
 
 
         /// <summary>

src/Microsoft.SqlTools.ServiceLayer/Scripting/ScriptAsScriptingOperation.cs

@@ -75,7 +75,8 @@ public override void Execute()
                 UrnCollection urns = CreateUrns(ServerConnection);
                 ScriptingOptions options = new ScriptingOptions();
                 SetScriptBehavior(options);
-                PopulateAdvancedScriptOptions(this.Parameters.ScriptOptions, options);
+                ScriptAsOptions scriptAsOptions = new ScriptAsOptions(this.Parameters.ScriptOptions);
+                PopulateAdvancedScriptOptions(scriptAsOptions, options);
                 options.WithDependencies = false;
                 // TODO: Not including the header by default. We have to get this option from client
                 options.IncludeHeaders = false;

test/Microsoft.SqlTools.ServiceLayer.IntegrationTests/Scripting/ScriptingServiceTests.cs

@@ -89,17 +89,25 @@ public async void ScriptingScript()
         [Fact]
         public async void VerifyScriptAsCreateTable()
         {
-            string query = "CREATE TABLE testTable1 (c1 int)";
+            string query = @"CREATE TABLE testTable1 (c1 int) 
+                            GO
+                            CREATE CLUSTERED INDEX [ClusteredIndex-1] ON [dbo].[testTable1]
+                            (
+	                            [c1] ASC
+                            )
+                            GO
+                            ";
             ScriptingOperationType scriptCreateDrop = ScriptingOperationType.Create;
             ScriptingObject scriptingObject = new ScriptingObject
             {
                 Name = "testTable1",
                 Schema = "dbo",
                 Type = "Table"
             };
-            string expectedScript = "CREATE TABLE [dbo].[testTable1]";
+            List<string> expectedScripts = new List<string> { "CREATE TABLE [dbo].[testTable1]", "CREATE CLUSTERED INDEX [ClusteredIndex-1] ON [dbo].[testTable1]" };
 
-            await VerifyScriptAs(query, scriptingObject, scriptCreateDrop, expectedScript);
+
+            await VerifyScriptAsForMultipleObjects(query, new List<ScriptingObject> { scriptingObject }, scriptCreateDrop, expectedScripts);
         }
 
         [Fact]