Bumping SMO to v180 (#2531)

* Updating SMO

* Porting updates to T4 templates

* Fixing vector test now that workaround has a real solution

Author: Benjin

Packages.props

@@ -66,7 +66,7 @@
   <ItemGroup>
     <PackageReference Update="Azure.Identity" Version="1.12.0" />
     <PackageReference Update="Microsoft.Data.SqlClient" Version="5.1.7" />
-    <PackageReference Update="Microsoft.SqlServer.SqlManagementObjects" Version="172.64.0" />
+    <PackageReference Update="Microsoft.SqlServer.SqlManagementObjects" Version="180.9.0-preview" />
     <PackageReference Update="Newtonsoft.Json" Version="13.0.3" />
   </ItemGroup>
 

src/Microsoft.SqlTools.ServiceLayer/Agent/AgentService.cs

@@ -223,7 +223,7 @@ internal async Task HandleJobHistoryRequest(AgentJobHistoryParams parameters, Re
                     result.Steps = jobSteps.ToArray();
 
                     // Add schedules to the job if any
-                    JobScheduleCollection schedules = jobs[parameters.JobName].JobSchedules;
+                    JobScheduleCollection<Job> schedules = jobs[parameters.JobName].JobSchedules;
                     var jobSchedules = new List<AgentScheduleInfo>();
                     foreach (JobSchedule schedule in schedules)
                     {
@@ -1480,7 +1480,7 @@ string targetDatabase
             result.Steps = jobSteps.ToArray();
 
             // add schedules to the job if any
-            JobScheduleCollection schedules = jobs[jobName].JobSchedules;
+            JobScheduleCollection<Job> schedules = jobs[jobName].JobSchedules;
             var jobSchedules = new List<AgentScheduleInfo>();
             foreach (JobSchedule schedule in schedules)
             {

src/Microsoft.SqlTools.ServiceLayer/Agent/Jobs/JobSchedulesData.cs

@@ -149,7 +149,7 @@ private void LoadData()
             // load the data
             if (job != null)
             {
-                JobScheduleCollection schedules = job.JobSchedules;
+                JobScheduleCollection<Job> schedules = job.JobSchedules;
 
                 for (int i = 0; i < schedules.Count; i++)
                 {

src/Microsoft.SqlTools.SqlCore/ObjectExplorer/SmoModel/SmoCollectionWrapper.cs

@@ -13,18 +13,20 @@ namespace Microsoft.SqlTools.SqlCore.ObjectExplorer.SmoModel
     /// <summary>
     /// Wrapper to convert non-generic Smo enumerables to generic enumerable types for easier use in 
     /// </summary>
-    /// <typeparam name="T"></typeparam>
-    public class SmoCollectionWrapper<T> : IEnumerable<T>
-        where T : SqlSmoObject
+    /// <typeparam name="TObject"></typeparam>
+    /// <typeparam name="TParent"></typeparam>
+    public class SmoCollectionWrapper<TObject, TParent> : IEnumerable<TObject>
+        where TObject : SqlSmoObject
+        where TParent : SqlSmoObject
     {
-        private SmoCollectionBase collection;
+        private SmoCollectionBase<TObject, TParent> collection;
 
         /// <summary>
         /// Constructor which accepts a <see cref="SmoCollectionBase"/> containing the objects
         /// to wrap 
         /// </summary>
         /// <param name="collection"><see cref="SmoCollectionBase"/> or null if none were set</param>
-        public SmoCollectionWrapper(SmoCollectionBase collection)
+        public SmoCollectionWrapper(SmoCollectionBase<TObject, TParent> collection)
         {
             this.collection = collection;
         }
@@ -33,15 +35,15 @@ public SmoCollectionWrapper(SmoCollectionBase collection)
         /// <see cref="IEnumerable{T}.GetEnumerator"/>
         /// </summary>
         /// <returns></returns>
-        public IEnumerator<T> GetEnumerator()
+        public IEnumerator<TObject> GetEnumerator()
         {
             if (collection == null)
             {
                 yield break;
             }
             foreach(Object obj in collection)
             {
-                yield return (T)obj;
+                yield return (TObject)obj;
             }
         }
 

src/Microsoft.SqlTools.SqlCore/ObjectExplorer/SmoModel/SmoColumnCustomNode.cs

@@ -212,12 +212,7 @@ internal static string GetTypeSpecifierLabel(DataType dataType, UserDefinedDataT
                         typeName += "(max)";
                         break;
                     case SqlDataType.Vector:
-                        // Temporary workaround to convert the maxLength to dimensions for vector types
-                        // until SMO is updated to store the actual dimensions of the vector type.
-                        // https://msdata.visualstudio.com/SQLToolsAndLibraries/_workitems/edit/3906463
-                        // dimensions = (length - 8) / 4
-                        // https://learn.microsoft.com/sql/t-sql/data-types/vector-data-type
-                        typeName += $"({(dataType.MaximumLength - 8) / 4})";
+                        typeName += $"({dataType.VectorDimensions})";
                         break;
                 }
             }