Make sure deprecated is always a string #2271
Open
+28
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DL files for consistency and clarity
…ndling of supported properties
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
HolgerJeromin
approved these changes
Dec 5, 2025
saschanaz
reviewed
Dec 6, 2025
| // The corresponding standardized property is not supported by | ||
| // anyone as of 2024-10. | ||
| property webkitLineClamp deprecated=#false | ||
| property webkitLineClamp supported=#true |
Contributor
There was a problem hiding this comment.
A better way would be to remove the field through removals, although it's not supported yet. Maybe that should be the first step.
Contributor
Author
There was a problem hiding this comment.
Can you share the syntax for it @saschanaz I can't imagine it
Contributor
There was a problem hiding this comment.
Something like
removals {
interface CSSStyleProperties {
property webkitLineClamp deprecated=#null
}
}Or perhaps it's easier to keep using each property's own type, like deprecated="" and let it converted to null via the removal conversion function. Either way would be fine for me.
Contributor
Author
|
Yay @saschanaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.