Support [LegacyFactoryFunction] (#869)

Author: saschanaz

baselines/dom.generated.d.ts

@@ -7075,6 +7075,7 @@ interface HTMLImageElement extends HTMLElement {
      * Sets or retrieves whether the image is a server-side image map.
      */
     isMap: boolean;
+    loading: string;
     /**
      * Sets or retrieves a Uniform Resource Identifier (URI) to a long description of the object.
      */

inputfiles/idl/HTML - Embedded content.widl

@@ -15,7 +15,7 @@ interface HTMLSourceElement : HTMLElement {
 };
 
 [Exposed=Window,
- NamedConstructor=Image(optional unsigned long width, optional unsigned long height)]
+ LegacyFactoryFunction=Image(optional unsigned long width, optional unsigned long height)]
 interface HTMLImageElement : HTMLElement {
   [HTMLConstructor] constructor();
 
@@ -34,6 +34,9 @@ interface HTMLImageElement : HTMLElement {
   readonly attribute USVString currentSrc;
   [CEReactions] attribute DOMString referrerPolicy;
   [CEReactions] attribute DOMString decoding;
+  [CEReactions] attribute DOMString loading;
 
   Promise<void> decode();
+
+  // also has obsolete members
 };

inputfiles/idl/HTML - Form elements.widl

@@ -76,9 +76,10 @@ interface HTMLOptGroupElement : HTMLElement {
 };
 
 [Exposed=Window,
- HTMLConstructor,
- NamedConstructor=Option(optional DOMString text = "", optional DOMString value, optional boolean defaultSelected = false, optional boolean selected = false)]
+ LegacyFactoryFunction=Option(optional DOMString text = "", optional DOMString value, optional boolean defaultSelected = false, optional boolean selected = false)]
 interface HTMLOptionElement : HTMLElement {
+  [HTMLConstructor] constructor();
+
   [CEReactions] attribute boolean disabled;
   readonly attribute HTMLFormElement? form;
   [CEReactions] attribute DOMString label;
@@ -110,7 +111,7 @@ interface HTMLTextAreaElement : HTMLElement {
 
   readonly attribute DOMString type;
   [CEReactions] attribute DOMString defaultValue;
-  attribute [TreatNullAs=EmptyString] DOMString value;
+  attribute [LegacyNullToEmptyString] DOMString value;
   readonly attribute unsigned long textLength;
 
   readonly attribute boolean willValidate;
@@ -201,4 +202,6 @@ interface HTMLLegendElement : HTMLElement {
   [HTMLConstructor] constructor();
 
   readonly attribute HTMLFormElement? form;
+
+  // also has obsolete members
 };

inputfiles/idl/HTML - Media.widl

@@ -11,7 +11,7 @@ interface HTMLVideoElement : HTMLMediaElement {
 };
 
 [Exposed=Window,
- NamedConstructor=Audio(optional DOMString src)]
+ LegacyFactoryFunction=Audio(optional DOMString src)]
 interface HTMLAudioElement : HTMLMediaElement {
   [HTMLConstructor] constructor();
 };
@@ -210,9 +210,10 @@ interface TimeRanges {
   double end(unsigned long index);
 };
 
-[Exposed=Window,
- Constructor(DOMString type, optional TrackEventInit eventInitDict = {})]
+[Exposed=Window]
 interface TrackEvent : Event {
+  constructor(DOMString type, optional TrackEventInit eventInitDict = {});
+
   readonly attribute (VideoTrack or AudioTrack or TextTrack)? track;
 };
 

src/widlprocess.ts

@@ -118,7 +118,7 @@ function convertInterfaceCommon(i: webidl2.InterfaceType | webidl2.InterfaceMixi
         "anonymous-methods": { method: [] },
         properties: { property: {}, namesakes: {} },
         constructor: getConstructor(i.members, i.name) || getOldStyleConstructor(i.extAttrs, i.name),
-        "named-constructor": getNamedConstructor(i.extAttrs, i.name),
+        "named-constructor": getLegacyFactoryFunction(i.extAttrs, i.name),
         exposed: getExtAttrConcatenated(i.extAttrs, "Exposed"),
         global: getExtAttrConcatenated(i.extAttrs, "Global"),
         "no-interface-object": hasExtAttr(i.extAttrs, "NoInterfaceObject") ? 1 : undefined,
@@ -210,9 +210,9 @@ function getOldStyleConstructor(extAttrs: webidl2.ExtendedAttribute[], parent: s
     }
 }
 
-function getNamedConstructor(extAttrs: webidl2.ExtendedAttribute[], parent: string): Browser.NamedConstructor | undefined {
+function getLegacyFactoryFunction(extAttrs: webidl2.ExtendedAttribute[], parent: string): Browser.NamedConstructor | undefined {
     for (const extAttr of extAttrs) {
-        if (extAttr.name === "NamedConstructor" && extAttr.rhs && typeof extAttr.rhs.value === "string") {
+        if (extAttr.name === "LegacyFactoryFunction" && extAttr.rhs && typeof extAttr.rhs.value === "string") {
             return {
                 name: extAttr.rhs.value,
                 signature: [{