Skip to content

Commit 657568c

Browse files
committed
jeff's feedback
1 parent ee16b0b commit 657568c

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,23 @@ We'll first need to set up a running instance of Metabase to serve the embedded
2525
1. Shut down Metabase if you already have it running on your machine.
2626
2. Download the [JAR file for Metabase OSS](https://www.metabase.com/start/oss/jar).
2727
3. Open up a terminal and clone this repo to your machine.
28-
4. Move the `metabase.jar` file to the `metabase` directory of this repo.
29-
5. Run the JAR file:
28+
4. Move the `metabase.jar` file from your downloads to the `/embedding-reference-apps/metabase` directory.
29+
5. `cd` into `/embedding-reference-apps/metabase`.
30+
6. Run the JAR file:
3031
```
3132
java -jar metabase.jar
3233
```
33-
6. [Run any example](#running-the-apps) depending on the programming language you choose.
34+
7. [Run any example](#running-the-apps) depending on the programming language you choose.
3435
3536
## Enable embedding
3637
3738
Once you've got Metabase running (on port 3000 by default):
3839
39-
1. Go to `localhost:3000` in your browser.
40+
1. Go to [`localhost:3000`](localhost:3000) in your browser.
4041
2. Log into Metabase.
4142
- User: plucky@admin.com
4243
- Password: Metabase123
4344
3. Go to **Admin settings** > **Embedding** and click the toggle.
44-
4. Make sure the embedding key in the **Admin settings** matches the embedding key in `index.js`.
4545
4646
## Running the apps
4747
@@ -57,7 +57,7 @@ To see an embedded Metabase dashboard in action, [set up Metabase](#set-up-metab
5757
5858
## Embedding charts or dashboards
5959
60-
There are three ways to embed Metabase charts or dashboards in web applications.
60+
There are different ways to embed Metabase charts or dashboards in web applications.
6161
6262
### Public embeds
6363

node/README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,19 @@ node index.js
2828

2929
Explore the app to learn more about embedding Metabase charts and dashboards in applications. You can also check out the links to more documentation in the parent repository's main [README](../README.md).
3030

31+
## Charts don't work
32+
33+
1. Go to your Metabase at `localhost:3000`.
34+
2. Click on the **gear** icon > **Admin settings**.
35+
3. Click **Embedding > **Standalone embeds**.
36+
4. Check that the embedding secret key matches the embedding key in `index.js`.
37+
5. If the keys don't match, copy the secret key from your **Admin settings** and replace the secret key in the `index.js` file.
38+
39+
If that doesn't work, try cloning a fresh repo and running a new JAR file.
40+
3141
## Example embedding code
3242

3343
You can find example code for Metabase embeds for:
3444

3545
- **Charts**. See [views/chart.pug](views/chart.pug).
3646
- **Dashboards**. See [views/dashboard.pug](views/dashboard.pug).
37-

0 commit comments

Comments
 (0)