Skip to content

Commit 5cf0f0d

Browse files
TroyGardenmeta-codesync[bot]
authored andcommitted
fix bug that causes servicelab issue (#3605)
Summary: Pull Request resolved: #3605 # context * previous change in `GPUMemoryStats` is causing issue in servicelabe * fix the bug > We found a Tupperware task failure only on the control side Reviewed By: spmex Differential Revision: D88860603 fbshipit-source-id: 4d65b232c5b1cd3da5024f5a0d74ad5743ea17db
1 parent 7b3effd commit 5cf0f0d

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

torchrec/distributed/benchmark/base.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -504,14 +504,6 @@ def wrapper() -> Any: # pyre-ignore [3]
504504
help="JSON config file for benchmarking",
505505
)
506506

507-
# Add loglevel argument with current logger level as default
508-
parser.add_argument(
509-
"--loglevel",
510-
type=str,
511-
default=logging._levelToName[logger.level],
512-
help="Set the logging level (e.g. info, debug, warning, error)",
513-
)
514-
515507
pre_args, _ = parser.parse_known_args()
516508

517509
yaml_defaults: Dict[str, Any] = (
@@ -531,7 +523,6 @@ def wrapper() -> Any: # pyre-ignore [3]
531523
seen_args = {
532524
"json_config",
533525
"yaml_config",
534-
"loglevel",
535526
}
536527

537528
for _name, param in sig.parameters.items():

torchrec/sparse/tests/jagged_tensor_benchmark.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def wrapped_func(
110110
short_name=name,
111111
gpu_elapsed_time=torch.tensor(times) * 1e3,
112112
cpu_elapsed_time=torch.tensor(times) * 1e3,
113-
gpu_mem_stats=[GPUMemoryStats(0, 0, 0, 0)],
113+
gpu_mem_stats=[GPUMemoryStats(0, 0, 0, 0, 0, 0)],
114114
cpu_mem_stats=[CPUMemoryStats.for_process(0)],
115115
)
116116

torchrec/sparse/tests/keyed_jagged_tensor_benchmark_lib.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ def benchmark_kjt(
233233
short_name=f"{test_name}-{transform_type.name}",
234234
gpu_elapsed_time=torch.tensor(times),
235235
cpu_elapsed_time=torch.tensor(times),
236-
gpu_mem_stats=[GPUMemoryStats(0, 0, 0, 0)],
236+
gpu_mem_stats=[GPUMemoryStats(0, 0, 0, 0, 0, 0)],
237237
cpu_mem_stats=[CPUMemoryStats.for_process(0)],
238238
)
239239

0 commit comments

Comments
 (0)