The mixing of differing integer types makes the search algorithms defective

[mclow]

Neil Groves wrote:
The mixing of differing integer types makes the search algorithms defective.
The int type is signed, and typically <= the size of std::size_t yet these
are mixed. The skip table uses ints, but std::size_t values are inserted.
Certainly there should not be any c style casts. It would seem logical to
use the boost::iterator_difference::type instead. Currently these
algorithms are defective albeit under unusual conditions.

There are numerous invocations of non-member functions that should use
qualified calls to avoid accidental argument-dependent lookup.

range_const_iterator has been deprecated in favour of
range_iterator

The Range versions of the functions should provide a non-const reference
version since there are no requirements for the interoperability of
range_iterator and range_iterator although they normally
exist..

[dabrahams]

It would be good to have tests implemented that demonstrate these defects before they are fixed.

[mclow]

I have pushed new versions of the search algorithms; I think I've resolved all the signed/unsigned comparisons, as well as removing all the c-style (I think).

[dabrahams]

What about the tests?

BTW, if you put "fixes #15" or "closes #15" in your commit comment we'd all be able to click on a link here and see the changes you made.

[mclow]

I didn't put that there because it's not completely fixed.
The ADL concerns have not been addressed, as well as the range types.

And, as you said, tests.

[dabrahams]

Oh, thanks. Well then refs or references #15 probably would work