-
Notifications
You must be signed in to change notification settings - Fork 10
Use SHA to reference GitHub Actions #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: technote-space/workflow-conclusion-action@v3 | ||
| - uses: technote-space/workflow-conclusion-action@45ce8e0eb155657ab8ccf346ade734257fd196a5 # v3.0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmoll this GitHub Action isn't supported anymore...
I'm not sure what type of output this was generation in the mo4 Slack Channel...
Options:
- keep it as it is, reminding that this might disappear in the future
- Delete it, if Slack isn't relevant
- Open a new Task, and fix it, as I don't have access to the Slack Channel ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this as-is and deal with it next year... personally I'm not against removing the Slack connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, now Slack is broken and the action needs either updating or removal 😂
|
@mmoll please 👀 this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 147 147
===========================================
Files 8 8
Lines 669 669
===========================================
Hits 669 669 ☔ View full report in Codecov by Sentry. |



Type of PR
Fixes Issues reported by SonarQube:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions
Breaking changes
Beside simply using the SHA for the versions, this also updates some of the GitHub Actions
Description
I use https://github.com/suzuki-shunsuke/pinact for is PR.