Skip to content

Conversation

@xalopp
Copy link
Contributor

@xalopp xalopp commented Dec 5, 2025

Type of PR

  • Bugfix
  • New Feature
  • Other (explain):

Fixes Issues reported by SonarQube:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Breaking changes

  • Yes, this is a breaking change

Beside simply using the SHA for the versions, this also updates some of the GitHub Actions

Description

I use https://github.com/suzuki-shunsuke/pinact for is PR.

runs-on: ubuntu-latest
steps:
- uses: technote-space/workflow-conclusion-action@v3
- uses: technote-space/workflow-conclusion-action@45ce8e0eb155657ab8ccf346ade734257fd196a5 # v3.0.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmoll this GitHub Action isn't supported anymore...

I'm not sure what type of output this was generation in the mo4 Slack Channel...

Options:

  1. keep it as it is, reminding that this might disappear in the future
  2. Delete it, if Slack isn't relevant
  3. Open a new Task, and fix it, as I don't have access to the Slack Channel ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this as-is and deal with it next year... personally I'm not against removing the Slack connection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, now Slack is broken and the action needs either updating or removal 😂

@xalopp
Copy link
Contributor Author

xalopp commented Dec 5, 2025

@mmoll please 👀 this PR

@xalopp xalopp mentioned this pull request Dec 5, 2025
4 tasks
@mmoll mmoll closed this Dec 8, 2025
@mmoll mmoll reopened this Dec 8, 2025
@mmoll mmoll closed this Dec 8, 2025
@mmoll mmoll reopened this Dec 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (93dad05) to head (1a5712a).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #227   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       147       147           
===========================================
  Files              8         8           
  Lines            669       669           
===========================================
  Hits             669       669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants