Skip to content

Commit dcafedd

Browse files
committed
Re-enable test
1 parent 9c97336 commit dcafedd

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

tests/reader_test.py

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,22 @@ def test_closed_get(self):
163163
# extension and the pure Python reader. If we do, the pure Python
164164
# reader will need to throw an exception or the extension will need
165165
# to keep the metadata in memory.
166-
#
167-
# def test_closed_metadata(self):
168-
# reader = Reader(
169-
# 'tests/data/test-data/MaxMind-DB-test-decoder.mmdb'
170-
# )
171-
# reader.close()
172-
173-
# self.assertRaisesRegex(IOError,
174-
# 'Attempt to read from a closed MaxMind DB.',
175-
# reader.metadata)
166+
def test_closed_metadata(self):
167+
reader = Reader(
168+
'tests/data/test-data/MaxMind-DB-test-decoder.mmdb'
169+
)
170+
reader.close()
171+
172+
# The primary purpose of this is to ensure the extension doesn't
173+
# segfault
174+
try:
175+
metadata = reader.metadata()
176+
except IOError as ex:
177+
self.assertEqual('Attempt to read from a closed MaxMind DB.',
178+
str(ex), 'extension throws exception')
179+
else:
180+
self.assertIsNotNone(
181+
metadata, 'pure Python implementation returns value')
176182

177183
def _check_metadata(self, reader, ip_version, record_size):
178184
metadata = reader.metadata()

0 commit comments

Comments
 (0)