Skip to content

Commit a568202

Browse files
committed
Get rid of unnecessary list in tests
1 parent 6379933 commit a568202

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

tests/reader_test.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,11 @@ def test_database_with_invalid_utf8_key(self):
286286

287287
def test_too_many_constructor_args(self):
288288
with self.assertRaises(TypeError):
289-
self.readerClass[0]("README.md", self.mode, 1)
289+
self.readerClass("README.md", self.mode, 1)
290290

291291
def test_bad_constructor_mode(self):
292292
with self.assertRaisesRegex(ValueError, r"Unsupported open mode \(100\)"):
293-
self.readerClass[0]("README.md", mode=100)
293+
self.readerClass("README.md", mode=100)
294294

295295
def test_no_constructor_args(self):
296296
with self.assertRaisesRegex(
@@ -300,7 +300,7 @@ def test_no_constructor_args(self):
300300
r"takes at least 2 arguments|"
301301
r"function missing required argument \'database\' \(pos 1\)",
302302
):
303-
self.readerClass[0]()
303+
self.readerClass()
304304

305305
def test_too_many_get_args(self):
306306
reader = open_database(
@@ -545,7 +545,7 @@ class TestExtensionReader(BaseTestReader, unittest.TestCase):
545545
mode = MODE_MMAP_EXT
546546

547547
if has_maxminddb_extension():
548-
readerClass = [maxminddb.extension.Reader]
548+
readerClass = maxminddb.extension.Reader
549549

550550

551551
@unittest.skipIf(
@@ -557,39 +557,39 @@ class TestExtensionReaderWithIPObjects(BaseTestReader, unittest.TestCase):
557557
use_ip_objects = True
558558

559559
if has_maxminddb_extension():
560-
readerClass = [maxminddb.extension.Reader]
560+
readerClass = maxminddb.extension.Reader
561561

562562

563563
class TestAutoReader(BaseTestReader, unittest.TestCase):
564564
mode = MODE_AUTO
565565

566566
if has_maxminddb_extension():
567-
readerClass = [maxminddb.extension.Reader]
567+
readerClass = maxminddb.extension.Reader
568568
else:
569-
readerClass = [maxminddb.reader.Reader]
569+
readerClass = maxminddb.reader.Reader
570570

571571

572572
class TestMMAPReader(BaseTestReader, unittest.TestCase):
573573
mode = MODE_MMAP
574-
readerClass = [maxminddb.reader.Reader]
574+
readerClass = maxminddb.reader.Reader
575575

576576

577577
# We want one pure Python test to use IP objects, it doesn't
578578
# really matter which one.
579579
class TestMMAPReaderWithIPObjects(BaseTestReader, unittest.TestCase):
580580
mode = MODE_MMAP
581581
use_ip_objects = True
582-
readerClass = [maxminddb.reader.Reader]
582+
readerClass = maxminddb.reader.Reader
583583

584584

585585
class TestFileReader(BaseTestReader, unittest.TestCase):
586586
mode = MODE_FILE
587-
readerClass = [maxminddb.reader.Reader]
587+
readerClass = maxminddb.reader.Reader
588588

589589

590590
class TestMemoryReader(BaseTestReader, unittest.TestCase):
591591
mode = MODE_MEMORY
592-
readerClass = [maxminddb.reader.Reader]
592+
readerClass = maxminddb.reader.Reader
593593

594594

595595
class TestFDReader(BaseTestReader, unittest.TestCase):
@@ -600,7 +600,7 @@ def setUp(self):
600600
self.open_database.side_effect = get_reader_from_file_descriptor
601601

602602
mode = MODE_FD
603-
readerClass = [maxminddb.reader.Reader]
603+
readerClass = maxminddb.reader.Reader
604604

605605

606606
class TestOldReader(unittest.TestCase):

0 commit comments

Comments
 (0)