Skip to content

Commit 8894525

Browse files
authored
Merge pull request #44 from maxmind/greg/fix-extension-warning
Fix extension warning with -Wdefault
2 parents 01df5d2 + c5f6141 commit 8894525

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

HISTORY.rst

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,13 @@
33
History
44
-------
55

6+
1.4.2
7+
++++++++++++++++++
8+
9+
* The extension source directory was moved to prevent an ``ImportWarning``
10+
when importing the module on Python 2 with ``-Wdefault`` set. Reported by
11+
David Szotten and Craig de Stigter. GitHub #31.
12+
613
1.4.1 (2018-06-22)
714
++++++++++++++++++
815

@@ -12,13 +19,13 @@ History
1219
++++++++++++++++++
1320

1421
* IMPORTANT: Previously, the pure Python reader would allow
15-
`ipaddress.IPv4Address` and `ipaddress.IPv6Address` objects when calling
16-
`.get()`. This would fail with the C extension. The fact that these objects
22+
``ipaddress.IPv4Address`` and ``ipaddress.IPv6Address`` objects when calling
23+
``.get()``. This would fail with the C extension. The fact that these objects
1724
worked at all was an implementation detail and has varied with different
1825
releases. This release makes the pure Python implementation consistent
19-
with the extension. A `TypeError` will now be thrown if you attempt to
26+
with the extension. A ``TypeError`` will now be thrown if you attempt to
2027
use these types with either the pure Python implementation or the
21-
extension. The IP address passed to `.get()` should be a string type.
28+
extension. The IP address passed to ``.get()`` should be a string type.
2229
* Fix issue where incorrect size was used when unpacking some types with the
2330
pure Python reader. Reported by Lee Symes. GitHub #30.
2431
* You may now pass in the database via a file descriptor rather than a file

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
Extension(
3434
'maxminddb.extension',
3535
libraries=['maxminddb'],
36-
sources=['maxminddb/extension/maxminddb.c'],
36+
sources=['extension/maxminddb.c'],
3737
extra_compile_args=compile_args,
3838
)
3939
]

0 commit comments

Comments
 (0)