ValueError rather than ImportError

Author: rafl

maxminddb/__init__.py

@@ -30,7 +30,7 @@ def open_database(database, mode=MODE_AUTO):
     has_extension = maxminddb.extension and hasattr(maxminddb.extension, 'Reader')
     if (mode == MODE_AUTO and has_extension) or mode == MODE_MMAP_EXT:
         if not has_extension:
-            raise ImportError(
+            raise ValueError(
                 "MODE_MMAP_EXT requires the maxminddb.extension module to be available")
         return maxminddb.extension.Reader(database)
     elif mode in (MODE_AUTO, MODE_MMAP, MODE_FILE, MODE_MEMORY):

tests/reader_test.py

@@ -97,7 +97,7 @@ def test_ipv6_address_in_ipv4_database(self):
     def test_no_extension_exception(self):
         real_extension = maxminddb.extension
         maxminddb.extension = None
-        with self.assertRaisesRegex(ImportError, 'MODE_MMAP_EXT requires the maxminddb.extension module to be available'):
+        with self.assertRaisesRegex(ValueError, 'MODE_MMAP_EXT requires the maxminddb.extension module to be available'):
             open_database(
             'tests/data/test-data/MaxMind-DB-test-decoder.mmdb', MODE_MMAP_EXT)
         maxminddb.extension = real_extension