-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Description
libhermes is incompatible with RN0.82
android/CMakeLists.txt should be updated
Here is the patch to solve for now:
diff --git a/node_modules/react-native-worklets-core/android/CMakeLists.txt b/node_modules/react-native-worklets-core/android/CMakeLists.txt
index cc4cbfe..9f94f1c 100644
--- a/node_modules/react-native-worklets-core/android/CMakeLists.txt
+++ b/node_modules/react-native-worklets-core/android/CMakeLists.txt
@@ -79,10 +79,18 @@ if(${JS_RUNTIME} STREQUAL "hermes")
string(APPEND CMAKE_CXX_FLAGS " -DJS_RUNTIME_HERMES=1")
- target_link_libraries(
- ${PACKAGE_NAME}
- hermes-engine::libhermes
- )
+ # For React Native 0.82+, use hermesvm instead of libhermes
+ if(ReactAndroid_VERSION_MINOR GREATER_EQUAL 82)
+ target_link_libraries(
+ ${PACKAGE_NAME}
+ hermes-engine::hermesvm
+ )
+ else()
+ target_link_libraries(
+ ${PACKAGE_NAME}
+ hermes-engine::libhermes
+ )
+ endif()
if(${HERMES_ENABLE_DEBUGGER})
if(ReactAndroid_VERSION_MINOR GREATER_EQUAL 76)
minhaz19, VinaChiong, scott-harrison, FernandoAOborges, rahulrajsbkk and 7 moreScriptureCoder and i7softhungga1711, tushe-tv, muzhaqi16, binarybase, unreal-work and 10 moreminhaz19, scott-harrison, ScriptureCoder, muzhaqi16, bacek97 and 1 more
Metadata
Metadata
Assignees
Labels
No labels