Skip to content

Plugin limited to 100 lists #186

@jonjennings

Description

@jonjennings

Describe the bug

If a user has more than 100 lists defined in MailChimp the plugin only fetches details for 100 of them making it impossible to connect the plugin to the other lists.

There are several places in the code where this limit is used - either for fetching the list from MailChimp or for populating the selection dropdown. Usually paired with a code comment along the lines of "// we *could* support paging, but 100 is more than enough for now." - well 100 isn't enough anymore :)

I'd suggest a quick fix might be to just bump the instances of this limit up to 150 or 200 to help your biggest customers. Maybe sort the list alphabetically to make it easier to navigate. Pagination seems like a big ask unless it's to reduce load or traffic.

Steps to Reproduce

  1. create more than 100 lists in a MailChimp account
  2. install the plugin and connect it to the MailChimp account
  3. copy the HTML from /wp-admin/admin.php?page=mailchimp_sf_options into an editor
  4. note that there are 101 (100 plus the 'select a list' placeholder) entries in the #mc_list_id dropdown

Screenshots, screen recording, code snippet

Not the only instance of this hard-coded limit:

Image

Environment information

Plugin version 2.0.0
WP version 6.8.3

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething isn't working.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions