Skip to content

Commit cc27599

Browse files
Revert "Merge branch 'ACQE-8918' into ACQE-functional-deployment-v4-7"
This reverts commit 9f34178, reversing changes made to dde69e8.
1 parent c502ef5 commit cc27599

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontVerifyCustomerDefaultCookieExpiryDateActionGroup.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<argument name="timeUnit" type="string" defaultValue="minute"/>
1818
</arguments>
1919

20-
<!--Generate expected date first to avoid race condition-->
21-
<generateDate date="{{timezoneOffset}} {{timeUnit}}" format="d/m/Y" timezone="UTC" stepKey="generateExpireDate"/>
22-
2320
<!--Verify that there are cookies exists with the given name `section_data_ids`, `mage-cache-sessid`, `mage-cache-storage`-->
2421
<seeCookie userInput="section_data_ids" stepKey="seeCookieForMagentoSectionDataIds"/>
2522
<seeCookie userInput="mage-cache-sessid" stepKey="seeCookieForMagentoCacheSessionId"/>
@@ -30,6 +27,9 @@
3027
<grabCookieAttributes userInput="mage-cache-sessid" stepKey="grabCookieForMagentoCacheSessionId"/>
3128
<grabCookieAttributes userInput="mage-cache-storage" stepKey="grabCookieForMagentoCacheStorage"/>
3229

30+
<!--Grab expected date-->
31+
<generateDate date="{{timezoneOffset}} {{timeUnit}}" format="d/m/Y" timezone="UTC" stepKey="generateExpireDate"/>
32+
3333
<!--Assert cookies `section_data_ids`, `mage-cache-sessid`, `mage-cache-storage` having expiry date equal to expected date-->
3434
<assertEquals stepKey="validateExpiryDateForMagentoDataIds">
3535
<actualResult type="string">{{$grabCookieForMagentoDataIds['expiry']}}</actualResult>

app/code/Magento/Customer/Test/Mftf/Test/StorefrontRetainLocalCacheStorageTest.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,15 @@
4343
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="loginCustomer">
4444
<argument name="Customer" value="$$createCustomer$$"/>
4545
</actionGroup>
46+
<see userInput="Welcome, $$createCustomer.firstname$$ $$createCustomer.lastname$$!" selector="{{StorefrontPanelHeaderSection.welcomeMessage}}" stepKey="checkWelcomeMessage"/>
4647

47-
<!--Verify default expiry date for cookies immediately after login to avoid race condition-->
48+
<!--Grab timezone offset-->
49+
<executeJS function="return -(new Date().getTimezoneOffset());" stepKey="getTimezoneOffset"/>
50+
<!--Verify default expiry date for cookies-->
4851
<actionGroup ref="StorefrontVerifyCustomerDefaultCookieExpiryDateActionGroup" stepKey="VerifyCookiesExpiryDate">
49-
<argument name="timezoneOffset" value="60"/>
52+
<argument name="timezoneOffset" value="{$getTimezoneOffset}"/>
5053
</actionGroup>
5154

52-
<see userInput="Welcome, $$createCustomer.firstname$$ $$createCustomer.lastname$$!" selector="{{StorefrontPanelHeaderSection.welcomeMessage}}" stepKey="checkWelcomeMessage"/>
53-
5455
<!--Logout customer before in case of it logged in from previous test-->
5556
<actionGroup ref="StorefrontCustomerLogoutActionGroup" stepKey="customerLogoutStorefront"/>
5657

@@ -86,9 +87,10 @@
8687
</actionGroup>
8788
<actionGroup ref="StorefrontClickSignOnCustomerLoginFormActionGroup" stepKey="clickSignInAccountButtonFirstAttempt"/>
8889

89-
<!--Verify cookies expiry date after 30 days immediately after login (cookie lifetime is set to 2592000 seconds = 43200 minutes)-->
90+
<!--Grab current timezone offset after 30 days-->
91+
<executeJS function="return {$getTimezoneOffset} + (30*24*60);" stepKey="getTimezoneOffsetAfterReset"/>
9092
<actionGroup ref="StorefrontVerifyCustomerDefaultCookieExpiryDateActionGroup" stepKey="VerifyCookiesExpiryDateAfterReset">
91-
<argument name="timezoneOffset" value="43200"/>
93+
<argument name="timezoneOffset" value="{$getTimezoneOffsetAfterReset}"/>
9294
</actionGroup>
9395
</test>
9496
</tests>

0 commit comments

Comments
 (0)