Skip to content

Commit b7eda07

Browse files
sandesh-shivakumarsandesh-shivakumar
committed
ACQE-8867: Order Management Asynchronous Grid Reindex
 - Fixed php static issues
1 parent 8a929d2 commit b7eda07

File tree

1 file changed

+53
-15
lines changed

1 file changed

+53
-15
lines changed

‎dev/tests/integration/testsuite/Magento/Sales/Model/CronJob/GridAsyncInsertCronTest.php‎

Lines changed: 53 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
use Magento\Framework\Api\SearchCriteriaBuilder;
1818
use Magento\Framework\App\ResourceConnection;
1919
use Magento\Framework\DB\Adapter\AdapterInterface;
20+
use Magento\Framework\Exception\LocalizedException;
2021
use Magento\Quote\Test\Fixture\AddProductToCart as AddProductToCartFixture;
2122
use Magento\Quote\Test\Fixture\GuestCart as GuestCartFixture;
2223
use Magento\Sales\Api\CreditmemoRepositoryInterface;
@@ -95,6 +96,7 @@ class GridAsyncInsertCronTest extends TestCase
9596
* Set up test dependencies
9697
*
9798
* @return void
99+
* @throws LocalizedException
98100
*/
99101
protected function setUp(): void
100102
{
@@ -127,10 +129,14 @@ protected function setUp(): void
127129
DataFixture(ProductFixture::class, as: 'product'),
128130
DataFixture(GuestCartFixture::class, as: 'cart'),
129131
DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$', 'email' => 'guest@example.com']),
130-
DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]),
132+
DataFixture(AddProductToCartFixture::class, [
133+
'cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1
134+
]),
131135
DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
132136
DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
133-
DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']),
137+
DataFixture(SetDeliveryMethodFixture::class, [
138+
'cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate'
139+
]),
134140
DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
135141
DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
136142
]
@@ -140,7 +146,12 @@ public function testOrderAsyncGridInsert(): void
140146
$orderId = (int)$order->getEntityId();
141147

142148
// Verify order exists in main table but NOT in grid
143-
$this->assertEntityInMainTableButNotInGrid('sales_order', 'sales_order_grid', $orderId, 'Order');
149+
$this->assertEntityInMainTableButNotInGrid(
150+
'sales_order',
151+
'sales_order_grid',
152+
$orderId,
153+
'Order'
154+
);
144155

145156
// Execute async grid insert directly
146157
$this->executeAsyncGridInsert('SalesOrderIndexGridAsyncInsert');
@@ -173,10 +184,14 @@ public function testOrderAsyncGridInsert(): void
173184
DataFixture(ProductFixture::class, as: 'product'),
174185
DataFixture(GuestCartFixture::class, as: 'cart'),
175186
DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$', 'email' => 'guest@example.com']),
176-
DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]),
187+
DataFixture(AddProductToCartFixture::class, [
188+
'cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1
189+
]),
177190
DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
178191
DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
179-
DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']),
192+
DataFixture(SetDeliveryMethodFixture::class, [
193+
'cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate'
194+
]),
180195
DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
181196
DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
182197
DataFixture(InvoiceFixture::class, ['order_id' => '$order.id$'], 'invoice'),
@@ -187,7 +202,12 @@ public function testInvoiceAsyncGridInsert(): void
187202
$invoiceId = (int)$invoice->getEntityId();
188203

189204
// Verify invoice exists in main table but NOT in grid
190-
$this->assertEntityInMainTableButNotInGrid('sales_invoice', 'sales_invoice_grid', $invoiceId, 'Invoice');
205+
$this->assertEntityInMainTableButNotInGrid(
206+
'sales_invoice',
207+
'sales_invoice_grid',
208+
$invoiceId,
209+
'Invoice'
210+
);
191211

192212
// Execute async grid insert directly
193213
$this->executeAsyncGridInsert('SalesInvoiceIndexGridAsyncInsert');
@@ -220,10 +240,14 @@ public function testInvoiceAsyncGridInsert(): void
220240
DataFixture(ProductFixture::class, as: 'product'),
221241
DataFixture(GuestCartFixture::class, as: 'cart'),
222242
DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$', 'email' => 'guest@example.com']),
223-
DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]),
243+
DataFixture(AddProductToCartFixture::class, [
244+
'cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1
245+
]),
224246
DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
225247
DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
226-
DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']),
248+
DataFixture(SetDeliveryMethodFixture::class, [
249+
'cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate'
250+
]),
227251
DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
228252
DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
229253
DataFixture(ShipmentFixture::class, ['order_id' => '$order.id$'], 'shipment'),
@@ -234,7 +258,12 @@ public function testShipmentAsyncGridInsert(): void
234258
$shipmentId = (int)$shipment->getEntityId();
235259

236260
// Verify shipment exists in main table but NOT in grid
237-
$this->assertEntityInMainTableButNotInGrid('sales_shipment', 'sales_shipment_grid', $shipmentId, 'Shipment');
261+
$this->assertEntityInMainTableButNotInGrid(
262+
'sales_shipment',
263+
'sales_shipment_grid',
264+
$shipmentId,
265+
'Shipment'
266+
);
238267

239268
// Execute async grid insert directly
240269
$this->executeAsyncGridInsert('SalesShipmentIndexGridAsyncInsert');
@@ -267,10 +296,14 @@ public function testShipmentAsyncGridInsert(): void
267296
DataFixture(ProductFixture::class, as: 'product'),
268297
DataFixture(GuestCartFixture::class, as: 'cart'),
269298
DataFixture(SetGuestEmailFixture::class, ['cart_id' => '$cart.id$', 'email' => 'guest@example.com']),
270-
DataFixture(AddProductToCartFixture::class, ['cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1]),
299+
DataFixture(AddProductToCartFixture::class, [
300+
'cart_id' => '$cart.id$', 'product_id' => '$product.id$', 'qty' => 1
301+
]),
271302
DataFixture(SetBillingAddressFixture::class, ['cart_id' => '$cart.id$']),
272303
DataFixture(SetShippingAddressFixture::class, ['cart_id' => '$cart.id$']),
273-
DataFixture(SetDeliveryMethodFixture::class, ['cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate']),
304+
DataFixture(SetDeliveryMethodFixture::class, [
305+
'cart_id' => '$cart.id$', 'carrier_code' => 'flatrate', 'method_code' => 'flatrate'
306+
]),
274307
DataFixture(SetPaymentMethodFixture::class, ['cart_id' => '$cart.id$', 'method' => 'checkmo']),
275308
DataFixture(PlaceOrderFixture::class, ['cart_id' => '$cart.id$'], 'order'),
276309
DataFixture(InvoiceFixture::class, ['order_id' => '$order.id$'], 'invoice'),
@@ -282,7 +315,12 @@ public function testCreditmemoAsyncGridInsert(): void
282315
$creditmemoId = (int)$creditmemo->getEntityId();
283316

284317
// Verify creditmemo exists in main table but NOT in grid
285-
$this->assertEntityInMainTableButNotInGrid('sales_creditmemo', 'sales_creditmemo_grid', $creditmemoId, 'Creditmemo');
318+
$this->assertEntityInMainTableButNotInGrid(
319+
'sales_creditmemo',
320+
'sales_creditmemo_grid',
321+
$creditmemoId,
322+
'Creditmemo'
323+
);
286324

287325
// Execute async grid insert directly
288326
$this->executeAsyncGridInsert('SalesCreditmemoIndexGridAsyncInsert');
@@ -327,7 +365,7 @@ private function executeAsyncGridInsert(string $virtualTypeName): void
327365
private function assertEntityInMainTableButNotInGrid(
328366
string $mainTable,
329367
string $gridTable,
330-
int $entityId,
368+
int $entityId,
331369
string $entityType
332370
): void {
333371
$entityInMainTable = $this->getEntityFromTable($mainTable, $entityId);
@@ -358,8 +396,8 @@ private function assertEntityInMainTableButNotInGrid(
358396
private function assertEntityInBothMainTableAndGrid(
359397
string $mainTable,
360398
string $gridTable,
361-
int $entityId,
362-
array $fieldsToCompare,
399+
int $entityId,
400+
array $fieldsToCompare,
363401
string $entityType
364402
): void {
365403
$entityInMainTable = $this->getEntityFromTable($mainTable, $entityId);

0 commit comments

Comments
 (0)