AC-15105: [CE] PHPUnit 12: Upgrade Payment & Shipping related test cases

Author: shashi011

app/code/Magento/CardinalCommerce/Test/Unit/Model/Response/JwtPayloadValidatorTest.php

@@ -7,6 +7,7 @@
 
 namespace Magento\CardinalCommerce\Test\Unit\Model\Response;
 
+use DateTimeZone;
 use Magento\CardinalCommerce\Model\Response\JwtPayloadValidator;
 use Magento\Framework\Intl\DateTimeFactory;
 use PHPUnit\Framework\TestCase;
@@ -29,7 +30,7 @@ protected function setUp(): void
 
     /**
      * Tests successful cases.
-     * 
+     *
      * @param array $token
      */
     #[DataProvider('validateSuccessDataProvider')]
@@ -62,6 +63,9 @@ public static function validateSuccessDataProvider()
 
     /**
      * Case when 3DS authentication is either failed or could not be attempted.
+     *
+     * @param array $token
+     * @dataProvider validationEciFailsDataProvider
      */
     #[DataProvider('validationEciFailsDataProvider')]
     public function testValidationEciFails(array $token)
@@ -90,7 +94,7 @@ public static function validationEciFailsDataProvider(): array
 
     /**
      * Case when resulting state of the transaction is negative.
-     * 
+     *
      * @param array $token
      */
     #[DataProvider('validationActionCodeFailsDataProvider')]
@@ -179,7 +183,7 @@ private static function createToken(string $eciFlag, string $errorNumber, string
     private static function getValidExpTimestamp()
     {
         $dateTimeFactory = new DateTimeFactory();
-        $currentDate = $dateTimeFactory->create('now', new \DateTimeZone('UTC'));
+        $currentDate = $dateTimeFactory->create('now', new DateTimeZone('UTC'));
 
         return $currentDate->getTimestamp() + 3600;
     }
@@ -192,7 +196,7 @@ private static function getValidExpTimestamp()
     private function getOutdatedExpTimestamp()
     {
         $dateTimeFactory = new DateTimeFactory();
-        $currentDate = $dateTimeFactory->create('now', new \DateTimeZone('UTC'));
+        $currentDate = $dateTimeFactory->create('now', new DateTimeZone('UTC'));
 
         return $currentDate->getTimestamp() - 3600;
     }

app/code/Magento/Payment/Test/Unit/Model/Method/FreeTest.php

@@ -82,6 +82,11 @@ protected function setUp(): void
 
     /**
      * Test get config payment action
+     *
+     * @param string $orderStatus
+     * @param string $paymentAction
+     * @param string|null $result
+     * @return void
      */
     #[DataProvider('getConfigPaymentActionProvider')]
     public function testGetConfigPaymentAction($orderStatus, $paymentAction, $result): void

app/code/Magento/Payment/Test/Unit/Model/PaymentMethodListTest.php

@@ -95,6 +95,12 @@ private function setUpGetList($paymentMethodConfig, $methodInstancesMap)
 
     /**
      * Test getList.
+     *
+     * @param int $storeId
+     * @param array $paymentMethodConfig
+     * @param array $methodInstancesMap
+     * @param array $expected
+     * @return void
      */
     #[DataProvider('getListDataProvider')]
     public function testGetList($storeId, $paymentMethodConfig, $methodInstancesMap, $expected)
@@ -130,8 +136,26 @@ public static function getListDataProvider()
                 1,
                 ['method_code_1' => [], 'method_code_2' => []],
                 [
-                    ['method_code_1', static fn (self $testCase) => $testCase->mockPaymentMethodInstance(1, 10, 'method_code_1', 'title', true)],
-                    ['method_code_2', static fn (self $testCase) => $testCase->mockPaymentMethodInstance(1, 5, 'method_code_2', 'title', true)]
+                    [
+                        'method_code_1',
+                        static fn (self $testCase) => $testCase->mockPaymentMethodInstance(
+                            1,
+                            10,
+                            'method_code_1',
+                            'title',
+                            true
+                        )
+                    ],
+                    [
+                        'method_code_2',
+                        static fn (self $testCase) => $testCase->mockPaymentMethodInstance(
+                            1,
+                            5,
+                            'method_code_2',
+                            'title',
+                            true
+                        )
+                    ]
                 ],
                 ['method_code_2', 'method_code_1']
             ]
@@ -140,6 +164,12 @@ public static function getListDataProvider()
 
     /**
      * Test getActiveList.
+     *
+     * @param int $storeId
+     * @param array $paymentMethodConfig
+     * @param array $methodInstancesMap
+     * @param array $expected
+     * @return void
      */
     #[DataProvider('getActiveListDataProvider')]
     public function testGetActiveList($storeId, $paymentMethodConfig, $methodInstancesMap, $expected)
@@ -175,8 +205,26 @@ public static function getActiveListDataProvider()
                 1,
                 ['method_code_1' => [], 'method_code_2' => []],
                 [
-                    ['method_code_1', static fn (self $testCase) => $testCase->mockPaymentMethodInstance(1, 10, 'method_code_1', 'title', false)],
-                    ['method_code_2', static fn (self $testCase) => $testCase->mockPaymentMethodInstance(1, 5, 'method_code_2', 'title', true)]
+                    [
+                        'method_code_1',
+                        static fn (self $testCase) => $testCase->mockPaymentMethodInstance(
+                            1,
+                            10,
+                            'method_code_1',
+                            'title',
+                            false
+                        )
+                    ],
+                    [
+                        'method_code_2',
+                        static fn (self $testCase) => $testCase->mockPaymentMethodInstance(
+                            1,
+                            5,
+                            'method_code_2',
+                            'title',
+                            true
+                        )
+                    ]
                 ],
                 ['method_code_2']
             ]

app/code/Magento/Payment/Test/Unit/Plugin/PaymentConfigurationProcessTest.php

@@ -67,6 +67,11 @@ protected function setUp(): void
 
     /**
      * Test before process
+     *
+     * @param array $jsLayout
+     * @param array $activePaymentList
+     * @param array $expectedResult
+     * @return void
      */
     #[DataProvider('beforeProcessDataProvider')]
     public function testBeforeProcess($jsLayout, $activePaymentList, $expectedResult)