AC-15105:[CE] PHPUnit 12: Upgrade Payment & Shipping related test cases

Author: shashi011

app/code/Magento/Vault/Test/Unit/Block/Customer/AccountTokensTest.php

@@ -38,10 +38,7 @@ protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
 
-        $this->tokenManagement = $this->getMockBuilder(CustomerTokenManagement::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['getCustomerSessionTokens'])
-            ->getMock();
+        $this->tokenManagement = $this->createMock(CustomerTokenManagement::class);
 
         $this->block = $this->objectManager->getObject(AccountTokens::class, [
             'customerTokenManagement' => $this->tokenManagement

app/code/Magento/Vault/Test/Unit/Model/AccountPaymentTokenFactoryTest.php

@@ -49,7 +49,7 @@ protected function setUp(): void
         ];
 
         $this->paymentToken = $objectManager->getObject(PaymentToken::class);
-        $this->objectManager = $this->getMockForAbstractClass(ObjectManagerInterface::class);
+        $this->objectManager = $this->createMock(ObjectManagerInterface::class);
 
         $this->paymentTokenFactory = new PaymentTokenFactory($this->objectManager, $tokenTypes);
         $this->factory = new AccountPaymentTokenFactory($this->objectManager, $this->paymentTokenFactory);

app/code/Magento/Vault/Test/Unit/Model/CreditCardTokenFactoryTest.php

@@ -44,7 +44,7 @@ protected function setUp(): void
         ];
 
         $this->paymentToken = $objectManager->getObject(PaymentToken::class);
-        $this->objectManager = $this->getMockForAbstractClass(ObjectManagerInterface::class);
+        $this->objectManager = $this->createMock(ObjectManagerInterface::class);
 
         $paymentTokenFactory = new PaymentTokenFactory($this->objectManager, $tokenTypes);
         $this->factory = new CreditCardTokenFactory($this->objectManager, $paymentTokenFactory);

app/code/Magento/Vault/Test/Unit/Model/CustomerTokenManagementTest.php

@@ -11,6 +11,7 @@
 use Magento\Vault\Api\Data\PaymentTokenInterface;
 use Magento\Vault\Model\CustomerTokenManagement;
 use Magento\Vault\Model\PaymentTokenManagement;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -33,12 +34,8 @@ class CustomerTokenManagementTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->paymentTokenManagement = $this->getMockBuilder(PaymentTokenManagement::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $this->customerSession = $this->getMockBuilder(Session::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->paymentTokenManagement = $this->createMock(PaymentTokenManagement::class);
+        $this->customerSession = $this->createMock(Session::class);
 
         $this->tokenManagement = new CustomerTokenManagement(
             $this->paymentTokenManagement,
@@ -50,8 +47,8 @@ protected function setUp(): void
      * @param int|null $customerId
      * @param bool $isLoggedCustomer
      * @return void
-     * @dataProvider getCustomerSessionTokensNegativeDataProvider
      */
+    #[DataProvider('getCustomerSessionTokensNegativeDataProvider')]
     public function testGetCustomerSessionTokensNegative($customerId, bool $isLoggedCustomer)
     {
         $this->customerSession->method('getCustomerId')->willReturn($customerId);
@@ -75,7 +72,7 @@ public static function getCustomerSessionTokensNegativeDataProvider()
     public function testGetCustomerSessionTokens()
     {
         $customerId = 1;
-        $token = $this->getMockForAbstractClass(PaymentTokenInterface::class);
+        $token = $this->createMock(PaymentTokenInterface::class);
         $expectation = [$token];
 
         $this->customerSession->expects(static::once())

app/code/Magento/Vault/Test/Unit/Model/Method/VaultTest.php

@@ -20,10 +20,12 @@
 use Magento\Sales\Api\Data\OrderPaymentExtensionInterface;
 use Magento\Sales\Api\Data\TransactionInterface;
 use Magento\Sales\Model\Order\Payment;
+use Magento\Framework\TestFramework\Unit\Helper\MockCreationTrait;
 use Magento\Vault\Api\Data\PaymentTokenInterface;
 use Magento\Vault\Api\PaymentTokenManagementInterface;
 use Magento\Vault\Model\Method\Vault;
 use Magento\Vault\Model\VaultPaymentInterface;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -32,6 +34,8 @@
  */
 class VaultTest extends TestCase
 {
+    use MockCreationTrait;
+
     /**
      * @var ObjectManager
      */
@@ -53,15 +57,15 @@ class VaultTest extends TestCase
     protected function setUp(): void
     {
         $this->objectManager = new ObjectManager($this);
-        $this->vaultProvider = $this->getMockForAbstractClass(MethodInterface::class);
+        $this->vaultProvider = $this->createMock(MethodInterface::class);
         $this->jsonSerializer = $this->createMock(Json::class);
     }
 
     public function testAuthorizeNotOrderPayment()
     {
         $this->expectException('DomainException');
         $this->expectExceptionMessage('Not implemented');
-        $paymentModel = $this->getMockForAbstractClass(InfoInterface::class);
+        $paymentModel = $this->createMock(InfoInterface::class);
 
         /** @var Vault $model */
         $model = $this->objectManager->getObject(Vault::class);
@@ -70,15 +74,13 @@ public function testAuthorizeNotOrderPayment()
 
     /**
      * @param array $additionalInfo
-     * @dataProvider additionalInfoDataProvider
      */
+    #[DataProvider('additionalInfoDataProvider')]
     public function testAuthorizeNoTokenMetadata(array $additionalInfo)
     {
         $this->expectException('LogicException');
         $this->expectExceptionMessage('Public hash should be defined');
-        $paymentModel = $this->getMockBuilder(Payment::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $paymentModel = $this->createMock(Payment::class);
 
         $paymentModel->expects(static::once())
             ->method('getAdditionalInformation')
@@ -109,10 +111,8 @@ public function testAuthorizeNoToken()
         $customerId = 1;
         $publicHash = 'token_public_hash';
 
-        $paymentModel = $this->getMockBuilder(Payment::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $tokenManagement = $this->getMockForAbstractClass(PaymentTokenManagementInterface::class);
+        $paymentModel = $this->createMock(Payment::class);
+        $tokenManagement = $this->createMock(PaymentTokenManagementInterface::class);
 
         $paymentModel->expects(static::once())
             ->method('getAdditionalInformation')
@@ -144,18 +144,17 @@ public function testAuthorize()
         $vaultProviderCode = 'vault_provider_code';
         $amount = 10.01;
 
-        $paymentModel = $this->getMockBuilder(Payment::class)
-            ->disableOriginalConstructor()
-            ->getMock();
-        $extensionAttributes = $this->getMockBuilder(OrderPaymentExtensionInterface::class)
-            ->addMethods(['setVaultPaymentToken', 'getVaultPaymentToken'])
-            ->getMockForAbstractClass();
+        $paymentModel = $this->createMock(Payment::class);
+        $extensionAttributes = $this->createPartialMockWithReflection(
+            OrderPaymentExtensionInterface::class,
+            ['setVaultPaymentToken', 'getVaultPaymentToken']
+        );
 
-        $commandManagerPool = $this->getMockForAbstractClass(CommandManagerPoolInterface::class);
-        $commandManager = $this->getMockForAbstractClass(CommandManagerInterface::class);
+        $commandManagerPool = $this->createMock(CommandManagerPoolInterface::class);
+        $commandManager = $this->createMock(CommandManagerInterface::class);
 
-        $tokenManagement = $this->getMockForAbstractClass(PaymentTokenManagementInterface::class);
-        $token = $this->getMockForAbstractClass(PaymentTokenInterface::class);
+        $tokenManagement = $this->createMock(PaymentTokenManagementInterface::class);
+        $token = $this->createMock(PaymentTokenInterface::class);
 
         $tokenDetails = [
             'cc_last4' => '1111',
@@ -226,7 +225,7 @@ public function testCaptureNotOrderPayment()
     {
         $this->expectException('DomainException');
         $this->expectExceptionMessage('Not implemented');
-        $paymentModel = $this->getMockForAbstractClass(InfoInterface::class);
+        $paymentModel = $this->createMock(InfoInterface::class);
 
         /** @var Vault $model */
         $model = $this->objectManager->getObject(Vault::class);
@@ -237,11 +236,9 @@ public function testCapture()
     {
         $this->expectException('DomainException');
         $this->expectExceptionMessage('Capture can not be performed through vault');
-        $paymentModel = $this->getMockBuilder(Payment::class)
-            ->disableOriginalConstructor()
-            ->getMock();
+        $paymentModel = $this->createMock(Payment::class);
 
-        $authorizationTransaction = $this->getMockForAbstractClass(TransactionInterface::class);
+        $authorizationTransaction = $this->createMock(TransactionInterface::class);
         $paymentModel->expects(static::once())
             ->method('getAuthorizationTransaction')
             ->willReturn($authorizationTransaction);
@@ -253,13 +250,13 @@ public function testCapture()
 
     /**
      * @covers       \Magento\Vault\Model\Method\Vault::isAvailable
-     * @dataProvider isAvailableDataProvider
      */
+    #[DataProvider('isAvailableDataProvider')]
     public function testIsAvailable($isAvailableProvider, $isActive, $expected)
     {
         $storeId = 1;
-        $quote = $this->getMockForAbstractClass(CartInterface::class);
-        $config = $this->getMockForAbstractClass(ConfigInterface::class);
+        $quote = $this->createMock(CartInterface::class);
+        $config = $this->createMock(ConfigInterface::class);
 
         $this->vaultProvider->expects(static::once())
             ->method('isAvailable')
@@ -310,7 +307,7 @@ public static function isAvailableDataProvider()
     public function testIsAvailableWithoutQuote()
     {
         $quote = null;
-        $config = $this->getMockForAbstractClass(ConfigInterface::class);
+        $config = $this->createMock(ConfigInterface::class);
 
         $this->vaultProvider->expects(static::once())
             ->method('isAvailable')
@@ -341,12 +338,12 @@ public function testIsAvailableWithoutQuote()
      * @param bool|null $configValue
      * @param bool|null $paymentValue
      * @param bool $expected
-     * @dataProvider internalUsageDataProvider
      */
+    #[DataProvider('internalUsageDataProvider')]
     public function testCanUseInternal($configValue, $paymentValue, $expected)
     {
-        $handlerPool = $this->getMockForAbstractClass(ValueHandlerPoolInterface::class);
-        $handler = $this->getMockForAbstractClass(ValueHandlerInterface::class);
+        $handlerPool = $this->createMock(ValueHandlerPoolInterface::class);
+        $handler = $this->createMock(ValueHandlerInterface::class);
 
         $handlerPool->expects(static::once())
             ->method('get')

app/code/Magento/Vault/Test/Unit/Model/PaymentMethodListTest.php

@@ -35,11 +35,8 @@ class PaymentMethodListTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->paymentMethodList = $this->getMockForAbstractClass(PaymentMethodListInterface::class);
-        $this->instanceFactory = $this->getMockBuilder(InstanceFactory::class)
-            ->disableOriginalConstructor()
-            ->onlyMethods(['create'])
-            ->getMock();
+        $this->paymentMethodList = $this->createMock(PaymentMethodListInterface::class);
+        $this->instanceFactory = $this->createMock(InstanceFactory::class);
 
         $this->vaultPaymentList = new PaymentMethodList($this->paymentMethodList, $this->instanceFactory);
     }
@@ -50,9 +47,9 @@ protected function setUp(): void
     public function testGetActivePaymentList()
     {
         $storeId = 1;
-        $vaultPayment = $this->getMockForAbstractClass(VaultPaymentInterface::class);
-        $paymentMethodInterface1 = $this->getMockForAbstractClass(PaymentMethodInterface::class);
-        $paymentMethodInterface2 = $this->getMockForAbstractClass(PaymentMethodInterface::class);
+        $vaultPayment = $this->createMock(VaultPaymentInterface::class);
+        $paymentMethodInterface1 = $this->createMock(PaymentMethodInterface::class);
+        $paymentMethodInterface2 = $this->createMock(PaymentMethodInterface::class);
         $activePayments = [
             $paymentMethodInterface1,
             $paymentMethodInterface2
@@ -66,7 +63,7 @@ public function testGetActivePaymentList()
         $this->instanceFactory->expects(static::exactly(2))
             ->method('create')
             ->willReturnMap([
-                [$paymentMethodInterface1, $this->getMockForAbstractClass(MethodInterface::class)],
+                [$paymentMethodInterface1, $this->createMock(MethodInterface::class)],
                 [$paymentMethodInterface2, $vaultPayment]
             ]);